Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for protobuf to OTLP exporter #2354

Closed
MikeGoldsmith opened this issue Jul 15, 2021 · 5 comments
Closed

Add support for protobuf to OTLP exporter #2354

MikeGoldsmith opened this issue Jul 15, 2021 · 5 comments
Assignees
Labels
enhancement New feature or request stale

Comments

@MikeGoldsmith
Copy link
Member

It would be good to update OTLP exporter to support exporting data using protobuf.

This is espcially useful, given that OTLP/HTTP JSON format is experimental where the binary format is stable.

Currently yes but the proto exporter could be fixed to works in browser i believe since it uses protobufjs which works on browser

Originally posted by @vmarchaud in #2322 (comment)

@vmarchaud vmarchaud added enhancement New feature or request up-for-grabs Good for taking. Extra help will be provided by maintainers labels Jul 15, 2021
@kolanos
Copy link

kolanos commented Jul 20, 2021

@vmarchaud
Copy link
Member

@kolanos It is, but it should be possible to use the proto encoding with the HTTP protocol, there already is one for node (https://github.com/open-telemetry/opentelemetry-js/tree/main/packages/opentelemetry-exporter-collector-proto) but it would be theorically possible to make it work in the browser (and so merge it with the normal exporter-collector)

@Anusha-Gurajapu
Copy link

I would like to pick this up. Please assign this to me.

@vmarchaud vmarchaud removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Aug 29, 2021
@github-actions
Copy link

github-actions bot commented Jan 5, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Jan 5, 2022
@dyladan
Copy link
Member

dyladan commented Jan 5, 2022

We currently support protobuf, json over http, and grpc

@dyladan dyladan closed this as completed Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

5 participants