-
Notifications
You must be signed in to change notification settings - Fork 795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregation Temporality Support #1730
Conversation
instrument.update(value); | ||
} | ||
// greater or equal then previous value. | ||
// However it is impractical for the stateless accumulator to remember |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As the aggregator in the Accumulator (class Metric
in the context) no longer bookkeeping all the records of past label-aggregator pairs, it is impractical for SumObserver to determine if it is updating with a rising value (unless the observer itself memos last value, but I'm not favoring the workaround). Some practices may recognize the value drop as a reset and correctly reflect the true trend, So I'd believe the value drop in SumObserver can reflect the true trends rather than discarding data frames.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SumObserver cannot have value drop, this is monotonic metric - it can only raise or remain the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you are right. I've checked again the status quo PR of the processor specs, SumObserver and
UpDownSumObserver instruments are configured for Cumulative aggregation temporality in StatelessAggregationTemporalitySelector
.
Codecov Report
@@ Coverage Diff @@
## master #1730 +/- ##
==========================================
- Coverage 91.38% 90.91% -0.47%
==========================================
Files 164 165 +1
Lines 5059 5153 +94
Branches 1048 1070 +22
==========================================
+ Hits 4623 4685 +62
- Misses 436 468 +32
|
Closed due to inactivity. I will continue the investigation once there are any updates on the spec. |
Which problem is this PR solving?
Short description of the changes
unbind
.AggregationTemporality.DELTA
aggregator snapshots toAggregationTemporality.CUMULATIVE
accumulations.move
andmerge
to Aggregator interfaces.This PR depends on previous minor type introductions: