Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce AggregatorSelector type #1712

Closed

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Dec 3, 2020

Which problem is this PR solving?

Short description of the changes

  • A new AggregatorSelector interface.
  • Processors implements AggregatorSelector interface.

Removes dependencies between metrics and processors
@codecov
Copy link

codecov bot commented Dec 3, 2020

Codecov Report

Merging #1712 (d740c23) into master (781b30f) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1712   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files         164      164           
  Lines        5059     5059           
  Branches     1048     1048           
=======================================
  Hits         4623     4623           
  Misses        436      436           
Impacted Files Coverage Δ
...ges/opentelemetry-metrics/src/SumObserverMetric.ts 100.00% <ø> (ø)
...entelemetry-metrics/src/UpDownSumObserverMetric.ts 100.00% <ø> (ø)
...s/opentelemetry-metrics/src/ValueObserverMetric.ts 100.00% <ø> (ø)
...es/opentelemetry-metrics/src/BaseObserverMetric.ts 100.00% <100.00%> (ø)
...s/opentelemetry-metrics/src/BatchObserverMetric.ts 93.10% <100.00%> (ø)
...ackages/opentelemetry-metrics/src/CounterMetric.ts 100.00% <100.00%> (ø)
...s/opentelemetry-metrics/src/UpDownCounterMetric.ts 100.00% <100.00%> (ø)
...s/opentelemetry-metrics/src/ValueRecorderMetric.ts 100.00% <100.00%> (ø)
...ages/opentelemetry-metrics/src/export/Processor.ts 92.00% <100.00%> (ø)

Base automatically changed from master to main January 25, 2021 19:26
@legendecas
Copy link
Member Author

Closed due to inactivity. I will continue the investigation once there are any updates on the spec.

@legendecas legendecas closed this Jun 24, 2021
@legendecas legendecas deleted the aggregator-selector branch September 27, 2021 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant