feat(plugin): add http plugin #161

OlivierAlbertini · 2019-08-04T23:37:35Z

UPDATE:

Increase the coverage and add fixes related to tests, Since we don't have exporter feature yet, I created a ProxyTracer (only for tests) in order to get spans. Perhaps, once we get exporter feature, we could refactor in order to use it, that should be simpler overall

UPDATE 2:

use bind method

Closes #157
Signed-off-by: Olivier Albertini [email protected]

Thanks in advance for your feedback!

packages/opentelemetry-node-tracer/src/NodeTracer.ts

packages/opentelemetry-plugin-http/src/http.ts

packages/opentelemetry-plugin-http/package.json

packages/opentelemetry-basic-tracer/src/BasicTracer.ts

vmarchaud · 2019-08-05T11:30:03Z

@OlivierAlbertini If you want some help don't hesitate to ping me on gitter (specially about the scopeManager use). I also speak french if you want

rochdev

There seem to be quite a few public methods. Is this intended? How is the plugin meant to be used?

packages/opentelemetry-basic-tracer/src/BasicTracer.ts

packages/opentelemetry-plugin-http/src/types.ts

packages/opentelemetry-plugin-http/src/http.ts

OlivierAlbertini · 2019-08-05T20:40:25Z

There seem to be quite a few public methods. Is this intended? How is the plugin meant to be used?

~~Public methods are statics and is it like that in order to reuse those methods for other plugins http2 / https or for people that would like to make their own plugin.~~

~~I'm open to change to protected if you prefer.~~

I created a separate static class

packages/opentelemetry-plugin-http/package.json

packages/opentelemetry-plugin-http/src/http.ts

mayurkale22 · 2019-08-05T22:03:12Z

I think you should add .DS_Store in .gitignore.

packages/opentelemetry-plugin-http/src/http.ts

mayurkale22 · 2019-08-05T22:24:21Z

This is great start 💯

Added a few comments (first iteration). Please fix the build and rebase with master.

packages/opentelemetry-plugin-http/package.json

mayurkale22 · 2019-08-06T00:44:18Z

yarn run fix should fix most of the lint issues.

OlivierAlbertini · 2019-08-06T00:55:04Z

yarn run fix should fix most of the lint issues.

yes, I got an issue where one package was on the gts 1.0.0 version instead of 1.1.0...
There was a comma feature conflict.

EDIT: I don't know what going on with my mac but I have clearly an issue with gts...
yarn run fix doesn't do the same thing that it does on circlesci or docker (with the same version of gts/node).

I will check a bit more why the issue is on my machine but my workaround is to do:
docker run -v $(pwd):/usr/src/lib -w "/usr/src/lib/packages/opentelemetry-plugin-http" ae28164cf6da yarn run fix

mayurkale22 · 2019-08-06T01:09:15Z

We are using nyc tool now, you should remove c8 dependency https://github.com/open-telemetry/opentelemetry-js/pull/161/files#diff-1a29b0926f59784792eb19ccaeffb380R48, looks like missed during rebase.

Also, I would suggest not to upgrade gts in this PR, to keep it small for code review. Feel free to open a separate PR for it.

codecov-io · 2019-08-06T03:49:17Z

Codecov Report

Merging #161 into master will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #161      +/-   ##
==========================================
- Coverage   94.59%   94.42%   -0.17%     
==========================================
  Files          51       51              
  Lines        1906     1849      -57     
  Branches      128      128              
==========================================
- Hits         1803     1746      -57     
  Misses        103      103

Impacted Files	Coverage Δ
...pe-async-hooks/test/AsyncHooksScopeManager.test.ts	`100% <0%> (ø)`	⬆️
...telemetry-scope-base/test/NoopScopeManager.test.ts	`100% <0%> (ø)`	⬆️

packages/opentelemetry-plugin-http/src/enums/attributes.ts

packages/opentelemetry-plugin-http/src/http.ts

packages/opentelemetry-plugin-http/src/utils.ts

OlivierAlbertini · 2019-08-06T12:46:12Z

Hi @rochdev

I added this issue #165

In order to avoid checking naming convention during PR review. Please feel free to comment and add your requirements.

Closes open-telemetry#157 Signed-off-by: Olivier Albertini <[email protected]>

Signed-off-by: Olivier Albertini <[email protected]>

test: increase coverage fix: attributes requirements from the spec. Signed-off-by: Olivier Albertini <[email protected]>

test: rename some tests fix: copy/paste tests Signed-off-by: Olivier Albertini <[email protected]>

fix parentSpanId instead of parentId from rebase add workaround with got and node12+ (real http call) improve args passed to function (url, options, cb) Signed-off-by: Olivier Albertini <[email protected]>

Signed-off-by: Olivier Albertini <[email protected]>

fix: add Flarna recommendations fix: tests fix: OC bugs in OT only test: add assertions Allow options object as second argument Signed-off-by: Olivier Albertini <[email protected]>

Signed-off-by: Olivier Albertini <[email protected]>

refactor: make integration tests mandatory for ci only remove duplicate tests remove dead comments Signed-off-by: Olivier Albertini <[email protected]>

mayurkale22 · 2019-08-30T22:27:53Z

I'm going to merge this PR. Let's address the remaining items and @todos after #232, #229 and #209. Thanks again for your contribution!

…dependencies

OlivierAlbertini requested review from danielkhan, iredelmeier, justindsmith, mayurkale22 and rochdev as code owners August 4, 2019 23:37

vmarchaud suggested changes Aug 5, 2019

View reviewed changes

rochdev reviewed Aug 5, 2019

View reviewed changes

mayurkale22 reviewed Aug 5, 2019

View reviewed changes

packages/opentelemetry-plugin-http/src/http.ts Outdated Show resolved Hide resolved

packages/opentelemetry-plugin-http/src/http.ts Outdated Show resolved Hide resolved

mayurkale22 reviewed Aug 5, 2019

View reviewed changes

packages/opentelemetry-plugin-http/src/http.ts Outdated Show resolved Hide resolved

mayurkale22 reviewed Aug 5, 2019

View reviewed changes

packages/opentelemetry-plugin-http/package.json Outdated Show resolved Hide resolved

OlivierAlbertini force-pushed the feature/http-plugin branch 2 times, most recently from 0b98274 to 284aaeb Compare August 5, 2019 23:55

OlivierAlbertini force-pushed the feature/http-plugin branch from 0e2d03f to 272b4b8 Compare August 6, 2019 00:45

OlivierAlbertini force-pushed the feature/http-plugin branch from 272b4b8 to 7e77c66 Compare August 6, 2019 01:09

OlivierAlbertini force-pushed the feature/http-plugin branch 4 times, most recently from bfbf65d to bec4e2c Compare August 6, 2019 03:47

OlivierAlbertini force-pushed the feature/http-plugin branch from bec4e2c to 710a491 Compare August 6, 2019 03:54

mayurkale22 reviewed Aug 6, 2019

View reviewed changes

OlivierAlbertini added 17 commits August 30, 2019 15:50

feat(plugin): add http plugin

4b140a3

Closes open-telemetry#157 Signed-off-by: Olivier Albertini <[email protected]>

fix: integrate vmarchaud recommandations

5922845

Signed-off-by: Olivier Albertini <[email protected]>

fix: wip revert - gts fix issue on all packages

1c73554

Signed-off-by: Olivier Albertini <[email protected]>

fix: integrate mayurkale22 recommendations

6a864fc

Signed-off-by: Olivier Albertini <[email protected]>

ci: gts fix for ci build

7a7845d

Signed-off-by: Olivier Albertini <[email protected]>

refactor: add mayurkale22 recommendations

42b0ac2

Signed-off-by: Olivier Albertini <[email protected]>

fix: integrate bg451 recommendations

f92a68c

test: increase coverage fix: attributes requirements from the spec. Signed-off-by: Olivier Albertini <[email protected]>

fix: add missing header and revert scopeManager to private field

96732c1

test: rename some tests fix: copy/paste tests Signed-off-by: Olivier Albertini <[email protected]>

fix: add tests and improve attributes from spec

8bb5afe

fix parentSpanId instead of parentId from rebase add workaround with got and node12+ (real http call) improve args passed to function (url, options, cb) Signed-off-by: Olivier Albertini <[email protected]>

fix: add mayurkale22 recommendations

147f8a9

Signed-off-by: Olivier Albertini <[email protected]>

fix: rebase and remove/replace wrapEmitter to bind

386a5e0

Signed-off-by: Olivier Albertini <[email protected]>

fix: add Flarna recommendations

0583832

fix: add Flarna recommendations fix: tests fix: OC bugs in OT only test: add assertions Allow options object as second argument Signed-off-by: Olivier Albertini <[email protected]>

refactor: simplify propagation usage

1714401

Signed-off-by: Olivier Albertini <[email protected]>

fix: add Flarna recommandations

d5e6531

Signed-off-by: Olivier Albertini <[email protected]>

refactor(test): use ReadableSpan

9e6215e

Signed-off-by: Olivier Albertini <[email protected]>

feat: export class/enums for https module

f3c1805

Signed-off-by: Olivier Albertini <[email protected]>

refactor: plugin.enable has logger param

d612642

Signed-off-by: Olivier Albertini <[email protected]>

OlivierAlbertini force-pushed the feature/http-plugin branch 3 times, most recently from 7312f03 to 23f745b Compare August 30, 2019 20:35

fix: add license header, rename enum files and refactoring

5b5dced

refactor: make integration tests mandatory for ci only remove duplicate tests remove dead comments Signed-off-by: Olivier Albertini <[email protected]>

OlivierAlbertini force-pushed the feature/http-plugin branch from 23f745b to 5b5dced Compare August 30, 2019 20:39

markwolff mentioned this pull request Aug 30, 2019

feat(plugin): add grpc plugin #215

Merged

3 tasks

mayurkale22 mentioned this pull request Aug 30, 2019

Nominating @OlivierAlbertini as JavaScript approver open-telemetry/community#166

Merged

mayurkale22 merged commit 3f90bf9 into open-telemetry:master Aug 30, 2019

OlivierAlbertini deleted the feature/http-plugin branch August 30, 2019 22:32

mayurkale22 mentioned this pull request Sep 10, 2019

Nominating @vmarchaud as JavaScript approver open-telemetry/community#177

Merged

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023

Merge pull request open-telemetry#161 from renovate-bot/renovate/pin-…

00ea26e

…dependencies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(plugin): add http plugin #161

feat(plugin): add http plugin #161

OlivierAlbertini commented Aug 4, 2019 •

edited

Loading

vmarchaud commented Aug 5, 2019

rochdev left a comment

OlivierAlbertini commented Aug 5, 2019 •

edited

Loading

mayurkale22 commented Aug 5, 2019

mayurkale22 commented Aug 5, 2019

mayurkale22 commented Aug 6, 2019

OlivierAlbertini commented Aug 6, 2019 •

edited

Loading

mayurkale22 commented Aug 6, 2019 •

edited

Loading

codecov-io commented Aug 6, 2019 •

edited

Loading

OlivierAlbertini commented Aug 6, 2019

mayurkale22 commented Aug 30, 2019

feat(plugin): add http plugin #161

feat(plugin): add http plugin #161

Conversation

OlivierAlbertini commented Aug 4, 2019 • edited Loading

vmarchaud commented Aug 5, 2019

rochdev left a comment

Choose a reason for hiding this comment

OlivierAlbertini commented Aug 5, 2019 • edited Loading

mayurkale22 commented Aug 5, 2019

mayurkale22 commented Aug 5, 2019

mayurkale22 commented Aug 6, 2019

OlivierAlbertini commented Aug 6, 2019 • edited Loading

mayurkale22 commented Aug 6, 2019 • edited Loading

codecov-io commented Aug 6, 2019 • edited Loading

Codecov Report

OlivierAlbertini commented Aug 6, 2019

mayurkale22 commented Aug 30, 2019

OlivierAlbertini commented Aug 4, 2019 •

edited

Loading

OlivierAlbertini commented Aug 5, 2019 •

edited

Loading

OlivierAlbertini commented Aug 6, 2019 •

edited

Loading

mayurkale22 commented Aug 6, 2019 •

edited

Loading

codecov-io commented Aug 6, 2019 •

edited

Loading