Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[http-plugin] Refactor tests once exporter available #209

Closed
OlivierAlbertini opened this issue Aug 19, 2019 · 3 comments · Fixed by #244
Closed

[http-plugin] Refactor tests once exporter available #209

OlivierAlbertini opened this issue Aug 19, 2019 · 3 comments · Fixed by #244
Labels
enhancement New feature or request

Comments

@OlivierAlbertini
Copy link
Member

OlivierAlbertini commented Aug 19, 2019 •
edited
Loading

Now, http plugin tests use several classes for auditing spans. Once this PR is merged #149 we should remove SpanAudit, SpanAuditProcessor and ProxyTracer in order to register a fake exporter.

This should reduce/simplify code.
@OlivierAlbertini OlivierAlbertini mentioned this issue Aug 19, 2019
Merged
@OlivierAlbertini OlivierAlbertini changed the title Refactor tests once exporter available [http-plugin] Refactor tests once exporter available Aug 19, 2019
@mayurkale22 mayurkale22 added the enhancement New feature or request label Aug 19, 2019
@OlivierAlbertini
Copy link
Member Author

OlivierAlbertini commented Aug 28, 2019 •
edited
Loading

SpanAudit has been removed for using ReadableSpan and ProxyTracer has been renamed to TracerTest since it has been simplified (it's not a proxy anymore)

@mayurkale22
Copy link
Member

@OlivierAlbertini I'd like to get your reviews on #234, this should help you to get ride of SpanAudit, SpanAuditProcessor and ProxyTracer in modules.

@mayurkale22
Copy link
Member

@OlivierAlbertini #234 is merged now, if you have the bandwidth feel free to take this one :)

OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Sep 10, 2019
@OlivierAlbertini
refactor(http-plugin): use SpanAuditProcessor
1a848d5 
Remove TracerTest
Remove SpanAuditProcessor
Closes open-telemetry#209

Signed-off-by: Olivier Albertini <[email protected]>
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Sep 10, 2019
@OlivierAlbertini
refactor(http-plugin): use SpanProcessor
d5c41f1 
Remove TracerTest
Remove SpanAuditProcessor
Closes open-telemetry#209

Signed-off-by: Olivier Albertini <[email protected]>
@OlivierAlbertini OlivierAlbertini mentioned this issue Sep 10, 2019
Merged
mayurkale22 pushed a commit that referenced this issue Sep 11, 2019
@OlivierAlbertini @mayurkale22
refactor(http-plugin): use SpanProcessor for tests (#244)
260a5e6 
* refactor(http-plugin): use SpanProcessor

Remove TracerTest
Remove SpanAuditProcessor
Closes #209

Signed-off-by: Olivier Albertini <[email protected]>

* refactor: add mayurkale22 recommendations

Signed-off-by: Olivier Albertini <[email protected]>
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@renovate-bot @obecny
chore(deps): update commitlint monorepo to v11 (open-telemetry#209)
5018164 
Co-authored-by: Bartlomiej Obecny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(http-plugin): use SpanProcessor for tests VilledeMontreal/opentelemetry-js
2 participants
@OlivierAlbertini @mayurkale22