feat(core): rename ProbabilitySampler to TraceIdRatioBasedSampler #1562
+209
−178
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TraceIdRatioBasedSampler are determinist samplers based on trace ids.
Which problem is this PR solving?
Short description of the changes
TraceIdRatioBased
sampler with a given sampling rate also sample all traces that anyTraceIdRatioBased
sampler with a lower sampling rate would sample.Note: per the time the PR is filed, the implementation detail of the sampler regarding the trace ids on spec is not yet determined. Though there will be no API changes regarding the new spec on this part, so it is safe to land the API with this primitive reminder based implemention.
This is a breaking change.