Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ProbabilitySampler to TraceIdRatioBasedSampler and implement ratio sampling #1487

Closed
dyladan opened this issue Sep 2, 2020 · 5 comments · Fixed by #1562
Closed

Rename ProbabilitySampler to TraceIdRatioBasedSampler and implement ratio sampling #1487

dyladan opened this issue Sep 2, 2020 · 5 comments · Fixed by #1562
Assignees

Comments

@dyladan
Copy link
Member

dyladan commented Sep 2, 2020

The probability sampler should be deterministic depending on the Trace ID.

https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#requirements-for-traceidratiobased-sampler-algorithm

@dyladan
Copy link
Member Author

dyladan commented Sep 2, 2020

Assigning this to @legendecas because he is already working on the parent sampled flag in the probability sampler and this issue is related.

@naseemkullah
Copy link
Member

do we need to rename OTEL_SAMPLING_PROBABILITY env var to OTEL_TRACE_ID_RATIO?

@dyladan
Copy link
Member Author

dyladan commented Sep 8, 2020

There is no spec for it, so I guess we can do what we want: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-environment-variables.md

I think probability is more clear to end users not familiar with our internals, and I think it is still accurate. Probability does not imply randomness.

@obecny
Copy link
Member

obecny commented Sep 30, 2020

@legendecas hey jsut wanted to ask what is the current status of this ticket, thx

@legendecas
Copy link
Member

@obecny I filed a PR #1562, please take a look at your convenience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants