-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename ProbabilitySampler to TraceIdRatioBasedSampler and implement ratio sampling #1487
Comments
Assigning this to @legendecas because he is already working on the parent sampled flag in the probability sampler and this issue is related. |
do we need to rename |
There is no spec for it, so I guess we can do what we want: https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/sdk-environment-variables.md I think probability is more clear to end users not familiar with our internals, and I think it is still accurate. Probability does not imply randomness. |
@legendecas hey jsut wanted to ask what is the current status of this ticket, thx |
The probability sampler should be deterministic depending on the Trace ID.
https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/sdk.md#requirements-for-traceidratiobased-sampler-algorithm
The text was updated successfully, but these errors were encountered: