Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include missing proto files in npm distribution #1539

Merged
merged 2 commits into from
Sep 21, 2020
Merged

fix: include missing proto files in npm distribution #1539

merged 2 commits into from
Sep 21, 2020

Conversation

blumamir
Copy link
Member

@blumamir blumamir commented Sep 16, 2020

Which problem is this PR solving?

#1538
#1524
proto files from build directory of @opentelemetry/exporter-collector-proto and @opentelemetry/exporter-collector-grpc are not published to npm in v0.11.0, causing error message about missing files to be logged when package is used, and exporter to not work.

Short description of the changes

Added the protos folder to the "files" section of package.json.
Validated the fix with npm publish --dry-run:

npm notice 304B   build/protos/opentelemetry/proto/collector/README.md                       
npm notice 2.9kB  build/protos/opentelemetry/proto/common/v1/common.proto                    
npm notice 1.9kB  build/protos/opentelemetry/proto/collector/metrics/v1/metrics_service.proto
npm notice 19.2kB build/protos/opentelemetry/proto/metrics/v1/metrics.proto                  
npm notice 1.3kB  build/protos/opentelemetry/proto/resource/v1/resource.proto                
npm notice 2.6kB  build/protos/opentelemetry/proto/trace/v1/trace_config.proto               
npm notice 2.0kB  build/protos/opentelemetry/proto/collector/trace/v1/trace_service.proto    
npm notice 11.1kB build/protos/opentelemetry/proto/trace/v1/trace.proto      

those files where missing before the change, and appear after the fix is applied.

Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx for spotting that

@codecov
Copy link

codecov bot commented Sep 16, 2020

Codecov Report

Merging #1539 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1539   +/-   ##
=======================================
  Coverage   93.82%   93.82%           
=======================================
  Files         154      154           
  Lines        4762     4762           
  Branches      951      951           
=======================================
  Hits         4468     4468           
  Misses        294      294           

@mayurkale22 mayurkale22 merged commit 56e3098 into open-telemetry:master Sep 21, 2020
mihirsoni pushed a commit to mihirsoni/opentelemetry-js that referenced this pull request Sep 21, 2020
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this pull request Dec 15, 2023
* chore: release main

* chore: release main
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 13, 2024
* chore: release main

* chore: release main
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this pull request Mar 16, 2024
* chore: release main

* chore: release main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants