Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exporter-collector-grpc && exporter-collector-proto: missing protos directory in v0.11.0 npm distribution #1538

Closed
blumamir opened this issue Sep 16, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@blumamir
Copy link
Member

What version of OpenTelemetry are you using?

v0.11.0

What version of Node are you using?

v12.18.3

What did you do?

After upgrade to v0.11.0, I tried to use the grpc exporter, and got the following error in log:

(node:21682) Warning: opentelemetry/proto/collector/trace/v1/trace_service.proto not found in any of the include paths /Users/amirblum/repos/aspecto-opentelemetry-js/node_modules/@opentelemetry/exporter-collector-grpc/build/protos
(node:21682) UnhandledPromiseRejectionWarning: Error: ENOENT: no such file or directory, open 'opentelemetry/proto/collector/trace/v1/trace_service.proto'

When I checked under the build directory of the npm distribution of @opentelemetry/exporter-collector-grpc, it is missing the protos folder.
I found the following npm script in package.json:
"protos:copy": "cpx protos/opentelemetry/**/*.* build/protos/opentelemetry". When building the project locally on my machine it does copy the protos folder to build directory, but they are not published to npm.
I think it's because they should be added under the "files" section in package.json:

  "files": [
    "build/src/**/*.js",
    "build/src/**/*.js.map",
    "build/src/**/*.d.ts",
    "build/src/**/*.proto",
    "doc",
    "LICENSE",
    "README.md"
  ],

If I copy the directory to my app node_modules under @opentelemetry/exporter-collector-grpc, everything works as expected

@blumamir blumamir added the bug Something isn't working label Sep 16, 2020
@vmarchaud
Copy link
Member

@blumamir Do you want to work on fixing this ?

@blumamir
Copy link
Member Author

@vmarchaud Yes I'll create a PR soon

@obecny obecny changed the title exporter-collector-grpc: missing protos directory in v0.11.0 npm distribution exporter-collector-grpc && exporter-collector-proto: missing protos directory in v0.11.0 npm distribution Sep 16, 2020
@obecny
Copy link
Member

obecny commented Sep 16, 2020

@blumamir it will be the same I have updated the title it is the same for proto

@dyladan
Copy link
Member

dyladan commented Sep 21, 2020

Can this be closed now?

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants