Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-inclusive language from tests #1500

Merged
merged 4 commits into from
Sep 9, 2020

Conversation

flands
Copy link
Contributor

@flands flands commented Sep 4, 2020

Which problem is this PR solving?

Addresses #1499

Short description of the changes

Remove non-inclusive language from tests

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #1500 into master will increase coverage by 2.24%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1500      +/-   ##
==========================================
+ Coverage   93.82%   96.06%   +2.24%     
==========================================
  Files         154       29     -125     
  Lines        4762     1373    -3389     
  Branches      951      316     -635     
==========================================
- Hits         4468     1319    -3149     
+ Misses        294       54     -240     
Impacted Files Coverage Δ
packages/opentelemetry-metrics/src/Meter.ts
...ry-plugin-xml-http-request/src/enums/EventNames.ts
packages/opentelemetry-metrics/src/Utils.ts
...telemetry-plugin-fetch/src/enums/AttributeNames.ts
...kages/opentelemetry-web/src/StackContextManager.ts
...s/opentelemetry-metrics/src/BatchObserverResult.ts
...entelemetry-metrics/src/MonotonicObserverResult.ts
...metry-core/src/trace/sampler/ProbabilitySampler.ts
...elemetry-api/src/correlation_context/EntryValue.ts
...ry-exporter-collector/src/CollectorExporterBase.ts
... and 115 more

Copy link
Member

@dyladan dyladan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you also do the same thing on the contrib repo?

@flands
Copy link
Contributor Author

flands commented Sep 4, 2020

Thanks! Can you also do the same thing on the contrib repo?

Yes, on my list :)

@flands
Copy link
Contributor Author

flands commented Sep 9, 2020

@open-telemetry/javascript-approvers can this be merged?

@dyladan dyladan merged commit 9469db5 into open-telemetry:master Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants