Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-inclusive language from tests #1499

Closed
flands opened this issue Sep 4, 2020 · 2 comments
Closed

Remove non-inclusive language from tests #1499

flands opened this issue Sep 4, 2020 · 2 comments

Comments

@flands
Copy link
Contributor

flands commented Sep 4, 2020

Is your feature request related to a problem? Please describe.

Non-inclusive language can be found in some tests

$ > git grep -Ei '(master|slave)' | grep -Evi '(tree|blob)/master' | grep test
packages/opentelemetry-plugin-fetch/test/fetch.test.ts:function createMasterResource(resource = {}): PerformanceResourceTiming {
packages/opentelemetry-plugin-fetch/test/fetch.test.ts:  const masterResource: any = createResource(resource);
packages/opentelemetry-plugin-fetch/test/fetch.test.ts:  Object.keys(masterResource).forEach((key: string) => {
packages/opentelemetry-plugin-fetch/test/fetch.test.ts:    if (typeof masterResource[key] === 'number') {
packages/opentelemetry-plugin-fetch/test/fetch.test.ts:      masterResource[key] = masterResource[key] + 30;
packages/opentelemetry-plugin-fetch/test/fetch.test.ts:  return masterResource;
packages/opentelemetry-plugin-fetch/test/fetch.test.ts:      createMasterResource({
packages/opentelemetry-plugin-xml-http-request/test/xhr.test.ts:function createMasterResource(resource = {}): PerformanceResourceTiming {
packages/opentelemetry-plugin-xml-http-request/test/xhr.test.ts:  const masterResource: any = createResource(resource);
packages/opentelemetry-plugin-xml-http-request/test/xhr.test.ts:  Object.keys(masterResource).forEach((key: string) => {
packages/opentelemetry-plugin-xml-http-request/test/xhr.test.ts:    if (typeof masterResource[key] === 'number') {
packages/opentelemetry-plugin-xml-http-request/test/xhr.test.ts:      masterResource[key] = masterResource[key] + 30;
packages/opentelemetry-plugin-xml-http-request/test/xhr.test.ts:  return masterResource;
packages/opentelemetry-plugin-xml-http-request/test/xhr.test.ts:            createMasterResource({
packages/opentelemetry-plugin-xml-http-request/test/xhr.test.ts:                'https://raw.githubusercontent.com/open-telemetry/opentelemetry-js/master/package.json',
packages/opentelemetry-plugin-xml-http-request/test/xhr.test.ts:                'https://raw.githubusercontent.com/open-telemetry/opentelemetry-js/master/package.json'
packages/opentelemetry-plugin-xml-http-request/test/xhr.test.ts:          'https://raw.githubusercontent.com/open-telemetry/opentelemetry-js/master/package.json';

Note: other non-inclusive language remains as a result of master terminology on branches.

Describe the solution you'd like

Non-inclusive language removed from tests

@dyladan
Copy link
Member

dyladan commented Sep 4, 2020

Any reason to limit this to just tests?

@dyladan
Copy link
Member

dyladan commented Sep 9, 2020

Fixed in #1500

@dyladan dyladan closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants