chore(jaeger): export ExporterConfig #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivkanya9146
requested review from
dyladan,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1478 +/- ##
==========================================
- Coverage 91.53% 91.19% -0.34%
==========================================
Files 155 165 +10
Lines 4891 5066 +175
Branches 1005 1037 +32
==========================================
+ Hits 4477 4620 +143
- Misses 414 446 +32
|
mayurkale22
approved these changes
Aug 31, 2020
dyladan
approved these changes
Aug 31, 2020
|
please fix the description of PR - the link fixes is broken |
|
Title says zipkin but the fix is actually applied to jaeger |
shivkanya9146
changed the title
Done |
obecny
approved these changes
Sep 29, 2020
pichlermarc
added a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* chore: document unmaintained components in yml * chore: add @seemk as component owner for instrumentation-bunyan Co-authored-by: Daniel Dyla <[email protected]> * chore: add @seemk as component owner for instrumentation-net Co-authored-by: Daniel Dyla <[email protected]> * chore: add @haddasbronfman as component owner for instrumentation-mysql2 * Update .github/component_owners.yml * Apply suggestions from code review * Add @seemk ownerships --------- Co-authored-by: Marc Pichler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of the changes
-Fixes #1443