Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JaegerExporter] ExporterConfig needs to be exported since it is API #1443

Closed
BryanHunt opened this issue Aug 18, 2020 · 2 comments · Fixed by #1478
Closed

[JaegerExporter] ExporterConfig needs to be exported since it is API #1443

BryanHunt opened this issue Aug 18, 2020 · 2 comments · Fixed by #1478
Assignees
Labels
bug Something isn't working

Comments

@BryanHunt
Copy link

Please answer these questions before submitting a bug report.

What version of OpenTelemetry are you using?

0.10.2

What version of Node are you using?

14.8.0

What did you do?

import { ExporterConfig } from '@opentelemetry/exporter-jaeger';
If possible, provide a recipe for reproducing the error.
import { ExporterConfig } from '@opentelemetry/exporter-jaeger';

What did you expect to see?

No errors

What did you see instead?

Module '"../node_modules/@opentelemetry/exporter-jaeger/build/src"' has no exported member 'ExporterConfig'.

Additional context

None
Add any other context about the problem here.

The JaegerExporter constructor requires the type ExporterConfig which is not exported from the module. It should be exported since it is part of the API.

@BryanHunt BryanHunt added the bug Something isn't working label Aug 18, 2020
@dyladan
Copy link
Member

dyladan commented Aug 21, 2020

Quick note. Since we actually have a package called API, we typically try to stay away from calling anything API that isn't specifically related to that package to avoid confusion. "public interface" might be a little less ambiguous. In any case, you're correct and it should be exported.

@shivkanya9146
Copy link
Contributor

I would like to work on this, please assign to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants