chore: transpile semantic conventions to es5 #1388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyladan
requested review from
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny,
OlivierAlbertini and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1388 +/- ##
=======================================
Coverage 94.03% 94.03%
=======================================
Files 149 149
Lines 4322 4322
Branches 880 880
=======================================
Hits 4064 4064
Misses 258 258 |
markwolff
approved these changes
Aug 4, 2020
Flarna
approved these changes
Aug 4, 2020
naseemkullah
approved these changes
Aug 5, 2020
mayurkale22
approved these changes
Aug 10, 2020
legendecas
approved these changes
Aug 10, 2020
vmarchaud
approved these changes
Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1368 this module may be used by other modules which wish to depend on the API. For instance a DB driver may want to call api methods and use the semconv package to ensure the attribute keys are always up to date. We should compile this back to es5 so that we don't restrict the compile targets of our dependents.