feat(api/context-base): change compile target to es5 #1368

markwolff · 2020-07-29T19:01:48Z

Which problem is this PR solving?

Fixes What about IE11 support? #902

Short description of the changes

Downgrade compile target of @opentelemetry/api & @opentelemetry/context-base (dependency of /api) es2017 ... es5

dyladan · 2020-07-29T19:04:47Z

Differences I have noticed between this and `ES2017` (current).

No use of class keyword
Use of var instead of const and let
No use of arrow functions

Use of Symbol, global, and globalThis appears to be unchanged.

codecov · 2020-07-29T19:07:55Z

Codecov Report

Merging #1368 into master will increase coverage by 0.42%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1368      +/-   ##
==========================================
+ Coverage   93.18%   93.61%   +0.42%     
==========================================
  Files         149      149              
  Lines        4228     4259      +31     
  Branches      869      869              
==========================================
+ Hits         3940     3987      +47     
+ Misses        288      272      -16

Impacted Files	Coverage Δ
packages/opentelemetry-api/src/trace/NoopSpan.ts	`100.00% <0.00%> (ø)`
packages/opentelemetry-api/src/trace/NoopTracer.ts	`100.00% <0.00%> (ø)`
...opentelemetry-api/src/metrics/NoopMeterProvider.ts	`100.00% <0.00%> (ø)`
...entelemetry-context-base/src/NoopContextManager.ts	`100.00% <0.00%> (ø)`
packages/opentelemetry-api/src/api/trace.ts	`90.90% <0.00%> (+5.19%)`	⬆️
packages/opentelemetry-api/src/api/context.ts	`83.87% <0.00%> (+8.87%)`	⬆️
packages/opentelemetry-api/src/api/propagation.ts	`55.88% <0.00%> (+9.21%)`	⬆️
...ackages/opentelemetry-api/src/metrics/NoopMeter.ts	`80.30% <0.00%> (+12.37%)`	⬆️
packages/opentelemetry-context-base/src/context.ts	`77.77% <0.00%> (+13.07%)`	⬆️
packages/opentelemetry-api/src/api/metrics.ts	`63.63% <0.00%> (+16.01%)`	⬆️
... and 2 more

ramya-rao-a · 2020-08-03T17:39:01Z

Can anyone share when we can expect this fix to be released in an update to the package?

dyladan · 2020-08-03T17:40:13Z

Are you waiting for this feature in particular? If so, we can probably push a release through fairly soon.

ramya-rao-a · 2020-08-03T18:25:54Z

Yes please :)

dyladan · 2020-08-03T19:00:20Z

Yes please :)

#1382 :)

…1368)

* feat: graceful shutdown for tracing and metrics * fix: wording in test case * fix: typo * fix meterprovider config to use bracket notation Co-authored-by: Daniel Dyla <[email protected]> * fix meterprovider config to use bracket notation Co-authored-by: Daniel Dyla <[email protected]> * fix: add callbacks to shutdown methods * fix: merge conflict * simplify meter shutdown code Co-authored-by: Daniel Dyla <[email protected]> * fix: fix one-liner * private function name style fix Co-authored-by: Daniel Dyla <[email protected]> * fix: naming of private member variables * fix: graceful shutdown now works in browser * fix: window event listener will trigger once * fix: modify global shutdown helper functions * fix: remove callback from remove listener args * fix: change global shutdown function names and simplify functionality * fix: add rest of function refactoring and simplification * fix: remove unintended code snippet * fix: refactor naming of listener cleanup function and fix sandbox issue * fix: make global shutdown cleanup local * fix: change interval of MeterProvider collection to ensure it does not trigger through clock * chore: removing _cleanupGlobalShutdownListeners * fix: remove unnecesary trace provider member function * Removing default span attributes (#1342) * refactor(opentelemetry-tracing): removing default span attributes Signed-off-by: Aravin Sivakumar <[email protected]> * refactor(opentelemetry-tracing): removing default span attributed from tracer object Signed-off-by: Aravin Sivakumar <[email protected]> * refactor(opentelemetry-tracing): removing accidental add to package.json Signed-off-by: Aravin Sivakumar <[email protected]> * refactor(opentelemetry-tracing): removing redundant test and fixing suggestions by Shawn and Daniel Signed-off-by: Aravin Sivakumar <[email protected]> * feat: add baggage support to the opentracing shim (#918) Co-authored-by: Mayur Kale <[email protected]> * Add nodejs sdk package (#1187) Co-authored-by: Naseem <[email protected]> Co-authored-by: legendecas <[email protected]> Co-authored-by: Mark Wolff <[email protected]> Co-authored-by: Matthew Wear <[email protected]> * feat: add OTEL_LOG_LEVEL env var (#974) * Proto update to latest to support arrays and maps (#1339) * chore: 0.10.0 release proposal (#1345) * fix: add missing grpc-js index (#1358) * chore: 0.10.1 release proposal (#1359) * feat(api/context-base): change compile target to es5 (#1368) * Feat: Make ID generator configurable (#1331) Co-authored-by: Daniel Dyla <[email protected]> * fix: require grpc-js instead of grpc in grpc-js example (#1364) Co-authored-by: Bartlomiej Obecny <[email protected]> * chore(deps): update all non-major dependencies (#1371) * chore: bump metapackage dependencies (#1383) * chore: 0.10.2 proposal (#1382) * fix: remove unnecesary trace provider member function * refactor(metrics): distinguish different aggregator types (#1325) Co-authored-by: Daniel Dyla <[email protected]> * Propagate b3 parentspanid and debug flag (#1346) * feat: Export MinMaxLastSumCountAggregator metrics to the collector as Summary (#1320) Co-authored-by: Daniel Dyla <[email protected]> * feat: Collector Metric Exporter for the Web (#1308) Co-authored-by: Daniel Dyla <[email protected]> * Fix issues in TypeScript getting started example code (#1374) Co-authored-by: Daniel Dyla <[email protected]> * chore: deploy canary releases (#1384) * fix: protos pull * fix: address marius' feedback * chore: deleting removeAllListeners from prometheus, fixing tests, cleanu of events when using shutdown notifier * fix: add documentation and cleanup code * fix: remove async label from shutdown and cleanup test case * fix: update controller collect to return promise * fix: make downsides of disabling graceful shutdown more apparent Co-authored-by: Daniel Dyla <[email protected]> Co-authored-by: Bartlomiej Obecny <[email protected]> Co-authored-by: Aravin <[email protected]> Co-authored-by: Ruben Vargas Palma <[email protected]> Co-authored-by: Mayur Kale <[email protected]> Co-authored-by: Naseem <[email protected]> Co-authored-by: legendecas <[email protected]> Co-authored-by: Mark Wolff <[email protected]> Co-authored-by: Matthew Wear <[email protected]> Co-authored-by: Naseem <[email protected]> Co-authored-by: Mark Wolff <[email protected]> Co-authored-by: Cong Zou <[email protected]> Co-authored-by: Reginald McDonald <[email protected]> Co-authored-by: WhiteSource Renovate <[email protected]> Co-authored-by: srjames90 <[email protected]> Co-authored-by: David W <[email protected]> Co-authored-by: Mick Dekkers <[email protected]>

…1368)

feat(api/context-base): change compile target to es5

54a144d

markwolff requested review from dyladan, legendecas, mayurkale22, mwear, naseemkullah, obecny, OlivierAlbertini and vmarchaud as code owners July 29, 2020 19:01

markwolff mentioned this pull request Jul 29, 2020

What about IE11 support? #902

Closed

2 tasks

dyladan approved these changes Jul 29, 2020

View reviewed changes

vmarchaud approved these changes Jul 29, 2020

View reviewed changes

naseemkullah approved these changes Jul 31, 2020

View reviewed changes

mayurkale22 approved these changes Jul 31, 2020

View reviewed changes

mayurkale22 merged commit 023541e into open-telemetry:master Jul 31, 2020

xirzec mentioned this pull request Jul 31, 2020

Cannot get storage-blob library to work in Angular 7 application using IE 11 Azure/azure-sdk-for-js#9702

Closed

5 tasks

dyladan added the enhancement New feature or request label Aug 3, 2020

ramya-rao-a mentioned this pull request Aug 4, 2020

Update @opentelemetry/api to latest version Azure/azure-sdk-for-js#10393

Merged

dyladan mentioned this pull request Aug 4, 2020

chore: transpile semantic conventions to es5 #1388

Merged

jonahrosenblum pushed a commit to jonahrosenblum/opentelemetry-js that referenced this pull request Aug 8, 2020

feat(api/context-base): change compile target to es5 (open-telemetry#…

0a0a487

…1368)

markwolff deleted the api/use-es5 branch November 15, 2020 07:28

dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022

feat(api/context-base): change compile target to es5 (open-telemetry#…

cc6286a

…1368)

dyladan pushed a commit to dyladan/opentelemetry-js that referenced this pull request Sep 9, 2022

feat(api/context-base): change compile target to es5 (open-telemetry#…

b236770

…1368)

mdbudnick mentioned this pull request Sep 19, 2022

@opentelemetry/auto-instrumentations-web not ES5 compatible open-telemetry/opentelemetry-js-contrib#1186

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(api/context-base): change compile target to es5 #1368

feat(api/context-base): change compile target to es5 #1368

markwolff commented Jul 29, 2020 •

edited

Loading

dyladan commented Jul 29, 2020 •

edited

Loading

codecov bot commented Jul 29, 2020 •

edited

Loading

ramya-rao-a commented Aug 3, 2020

dyladan commented Aug 3, 2020

ramya-rao-a commented Aug 3, 2020

dyladan commented Aug 3, 2020

feat(api/context-base): change compile target to es5 #1368

feat(api/context-base): change compile target to es5 #1368

Conversation

markwolff commented Jul 29, 2020 • edited Loading

Which problem is this PR solving?

Short description of the changes

dyladan commented Jul 29, 2020 • edited Loading

Differences I have noticed between this and ES2017 (current).

codecov bot commented Jul 29, 2020 • edited Loading

Codecov Report

ramya-rao-a commented Aug 3, 2020

dyladan commented Aug 3, 2020

ramya-rao-a commented Aug 3, 2020

dyladan commented Aug 3, 2020

markwolff commented Jul 29, 2020 •

edited

Loading

dyladan commented Jul 29, 2020 •

edited

Loading

Differences I have noticed between this and `ES2017` (current).

codecov bot commented Jul 29, 2020 •

edited

Loading