Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the missing plugin dependencies in tracing example #1078

Merged
merged 3 commits into from
May 26, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add the missing plugin dependencies in tracing example
Currently running the node app shows an error message in loading the express and https opentelemetry plugins. Add the two modules as dependencies to resolve this error.
kanikashah90 committed May 19, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit a0eb42c21af815b4e369d2b6f13cc9ebf566dccf
2 changes: 2 additions & 0 deletions getting-started/traced-example/package.json
Original file line number Diff line number Diff line change
@@ -12,7 +12,9 @@
"@opentelemetry/core": "^0.8.1",
"@opentelemetry/exporter-zipkin": "^0.8.1",
"@opentelemetry/node": "^0.8.1",
"@opentelemetry/plugin-express": "^0.7.0",
"@opentelemetry/plugin-http": "^0.8.1",
"@opentelemetry/plugin-https": "^0.8.1",
"@opentelemetry/tracing": "^0.8.1",
"axios": "^0.19.0",
"express": "^4.17.1"