Add the missing plugin dependencies in tracing example #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently running the node app shows an error message in loading the express and https opentelemetry plugins. Add the two modules as dependencies to resolve this error.
kanikashah90
requested review from
bg451,
dyladan,
markwolff,
mayurkale22,
obecny,
OlivierAlbertini,
rochdev and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1078 +/- ##
=======================================
Coverage 94.98% 94.98%
=======================================
Files 238 238
Lines 9085 9085
Branches 822 822
=======================================
Hits 8629 8629
Misses 456 456 |
dyladan
approved these changes
May 19, 2020
|
Does this fix #1076 ? |
mayurkale22
approved these changes
May 19, 2020
|
Please sign the CLA (https://identity.linuxfoundation.org/projects/cncf). |
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently running the node app shows an error message in loading the express and https opentelemetry plugins. Add the two modules as dependencies to resolve this error.