-
Notifications
You must be signed in to change notification settings - Fork 828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTTP attributes are noncomformant #635
Comments
I'm closing this issue since it's a duplicated of #373. Feel free to discuss on this one or reopen if you are not agreed |
Well it's not exactly a duplicate because IIRC |
Yes. OpenTelemetry didn't provide a spec when we start to write http plugin (OpenCensus spec was used) and when they did they didn't provide something about host or target. Also I think that we are not the only one who did that open-telemetry/opentelemetry-dotnet@faa2b38#diff-27ba31dbe3c643485ab4e902909cd984R26 ... Btw, it's not a big deal and we will sync to new spec version. |
Please compare
opentelemetry-js/packages/opentelemetry-plugin-http/src/enums/AttributeNames.ts
Lines 21 to 24 in af5a364
The text was updated successfully, but these errors were encountered: