Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP attributes are noncomformant #635

Closed
Oberon00 opened this issue Dec 18, 2019 · 3 comments
Closed

HTTP attributes are noncomformant #635

Oberon00 opened this issue Dec 18, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@Oberon00
Copy link
Member

Please compare

HTTP_HOSTNAME = 'http.hostname',
COMPONENT = 'component',
HTTP_METHOD = 'http.method',
HTTP_PATH = 'http.path',
with https://github.com/open-telemetry/opentelemetry-specification/blob/8f4377c15e44e1d9348edec7cabea2a7107a6877/specification/data-http.md. There is no http.hostname (there are net.host.name and http.host and http.server_name though), and there is no http.path (there is http.target though which may or may not be what http.path was meant for).

@Oberon00 Oberon00 added the bug Something isn't working label Dec 18, 2019
@dyladan dyladan assigned dyladan and unassigned dyladan Dec 18, 2019
@OlivierAlbertini
Copy link
Member

I'm closing this issue since it's a duplicated of #373. Feel free to discuss on this one or reopen if you are not agreed

@Oberon00
Copy link
Member Author

Well it's not exactly a duplicate because IIRC http.path and http.hostname did never exist in the semantic conventions for OpenTelemetry.

@OlivierAlbertini
Copy link
Member

OlivierAlbertini commented Dec 19, 2019

Well it's not exactly a duplicate because IIRC http.path and http.hostname did never exist in the semantic conventions for OpenTelemetry.

Yes. OpenTelemetry didn't provide a spec when we start to write http plugin (OpenCensus spec was used) and when they did they didn't provide something about host or target.

https://github.com/open-telemetry/opentelemetry-specification/blob/600149f531ad62efb3a3dc96007781c3604ebdec/specification/data-semantic-conventions.md

Also I think that we are not the only one who did that
e.g https://github.com/open-telemetry/opentelemetry-go/blob/b863b8f6ab9eff876b15ef36e1192e1ddfd0f91d/plugin/othttp/handler.go#L33

open-telemetry/opentelemetry-dotnet@faa2b38#diff-27ba31dbe3c643485ab4e902909cd984R26

...

Btw, it's not a big deal and we will sync to new spec version.
Thanks @Oberon00 for the heads up and noticing this.

pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
martinkuba pushed a commit to martinkuba/opentelemetry-js that referenced this issue Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants