Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugin-http] attribute specs update #373

Closed
OlivierAlbertini opened this issue Sep 29, 2019 · 1 comment · Fixed by #643
Closed

[plugin-http] attribute specs update #373

OlivierAlbertini opened this issue Sep 29, 2019 · 1 comment · Fixed by #643
Assignees
@OlivierAlbertini
Labels
enhancement New feature or request
Milestone
Alpha v0.3.2

Comments

@OlivierAlbertini
Copy link
Member

There is new attributes and some of them have been renamed.
Ref: open-telemetry/opentelemetry-specification#263
@OlivierAlbertini OlivierAlbertini added the enhancement New feature or request label Sep 29, 2019
@OlivierAlbertini OlivierAlbertini self-assigned this Sep 29, 2019
@OlivierAlbertini OlivierAlbertini changed the title [plugin-http] attribute specs updates [plugin-http] attribute specs update Sep 29, 2019
@Oberon00
Copy link
Member

Oberon00 commented Sep 30, 2019 •
edited
Loading

Note that this PR is fresh and not approved yet. I wouldn't start implementing this just now, as it is not unlikely that it will change in response to reviews.

EDIT: BTW, you are welcome to also give your feedback on the PR, if you are interested in the topic.

@OlivierAlbertini OlivierAlbertini mentioned this issue Dec 18, 2019
Closed
OlivierAlbertini added a commit to VilledeMontreal/opentelemetry-js that referenced this issue Dec 21, 2019
@OlivierAlbertini
feat(plugin-http): add/modify attributes
01a89b7 
closes open-telemetry#373, open-telemetry#394

Signed-off-by: Olivier Albertini <[email protected]>
@OlivierAlbertini OlivierAlbertini mentioned this issue Dec 21, 2019
Merged
@mayurkale22 mayurkale22 added this to the Alpha v0.3.2 milestone Dec 23, 2019
mayurkale22 added a commit that referenced this issue Jan 2, 2020
@OlivierAlbertini @mayurkale22
feat(plugin-http): add/modify attributes (#643)
3d9b822 
* feat(plugin-http): add/modify attributes

closes #373, #394

Signed-off-by: Olivier Albertini <[email protected]>

* fix: change remotePort to localPort

refactor: remove useless checks
test: add assertions

Signed-off-by: Olivier Albertini <[email protected]>

* test(plugin-https): sync with http plugin

Signed-off-by: Olivier Albertini <[email protected]>

Co-authored-by: Mayur Kale <[email protected]>
lukaswelinder pushed a commit to agile-pm/opentelemetry-js that referenced this issue Jul 24, 2020
@yurishkuro
Port refactoring/cleanup from PR 372 (open-telemetry#373)
559045f 
Signed-off-by: Yuri Shkuro <[email protected]>
pichlermarc pushed a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue Dec 15, 2023
@z1c0
Update README.md (open-telemetry#373)
20c59e1 
Fix markdown typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlivierAlbertini OlivierAlbertini

Labels
enhancement New feature or request
Projects
None yet
Milestone
Alpha v0.3.2
Development

Successfully merging a pull request may close this issue.

feat(plugin-http): add/modify attributes VilledeMontreal/opentelemetry-js
3 participants
@Oberon00 @OlivierAlbertini @mayurkale22