New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move examples that depends on contrib repo to contrib repo #1812

Closed

obecny opened this issue Jan 12, 2021 · 1 comment

Labels

feature-request up-for-grabs

Member

obecny commented Jan 12, 2021

This is to avoid some cross dependency especially during update and also to clean things up

obecny added feature-request up-for-grabs release:required-for-ga labels

CptSchnitz mentioned this issue

Ensure all examples are working #2346

Closed

Member

pichlermarc commented Nov 30, 2021

I think this issue was fixed by #2028
I went though the examples again and it seems like none of them depend on the contrib repository anymore.

obecny closed this as completed

pichlermarc mentioned this issue

REQUEST: New membership for @pichlermarc open-telemetry/community#1039

Closed

6 tasks

pichlermarc added a commit to dynatrace-oss-contrib/opentelemetry-js that referenced this issue


          chore(instrumentation-mysql2): drop unneed @types/mysql2 dep (open-te…

434cab2

…lemetry#1812)

Types are included in 'mysql2' now (as of some 2.x release).

The github:types/mysql2 dependency is problematic for dependabot version updates.
See: open-telemetry/opentelemetry-js-contrib#1806 (comment)

Co-authored-by: Marc Pichler <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment