Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all examples are working #2346

Closed
dyladan opened this issue Jul 14, 2021 · 4 comments
Closed

Ensure all examples are working #2346

dyladan opened this issue Jul 14, 2021 · 4 comments
Assignees

Comments

@dyladan
Copy link
Member

dyladan commented Jul 14, 2021

All examples should be working before we go to GA. This may require updating some of the examples API 1.x.

@dyladan dyladan added up-for-grabs Good for taking. Extra help will be provided by maintainers release:required-for-ga labels Jul 14, 2021
@CptSchnitz
Copy link
Contributor

Hi i would like to work on this.
two quick questions:

  1. If i find some problems, should i open a PR for each example or one big PR for everything?
  2. Is Move examples that depends on contrib repo to contrib repo #1812 also relevant to this?

@Flarna
Copy link
Member

Flarna commented Jul 15, 2021

I think if a change needed is just a missing import, some minor rename or change of a version it's fine to combine several fixes in one PR. But if there is more to do a dedicated PR is usually better.

@CptSchnitz
Copy link
Contributor

I went over all of the examples, and all of them worked except metrics, Prometheus and opentracing-shim that were missing @opentelemetry/api so it was impossible to run them.
I opened a PR to fix those, and upgrade the @opentelemetry/api version for all of them to the latest.

@dyladan
Copy link
Member Author

dyladan commented Aug 3, 2021

Fixed by #2358

@dyladan dyladan closed this as completed Aug 3, 2021
@dyladan dyladan removed the up-for-grabs Good for taking. Extra help will be provided by maintainers label Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants