-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure all examples are working #2346
Comments
Hi i would like to work on this.
|
I think if a change needed is just a missing import, some minor rename or change of a version it's fine to combine several fixes in one PR. But if there is more to do a dedicated PR is usually better. |
I went over all of the examples, and all of them worked except metrics, Prometheus and opentracing-shim that were missing @opentelemetry/api so it was impossible to run them. |
Fixed by #2358 |
All examples should be working before we go to GA. This may require updating some of the examples API 1.x.
The text was updated successfully, but these errors were encountered: