-
Notifications
You must be signed in to change notification settings - Fork 532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update OTel deps #954
Conversation
That's because if we let api float, every other api-dependent package has to be able to float as well.
Codecov Report
@@ Coverage Diff @@
## main #954 +/- ##
==========================================
- Coverage 95.91% 92.02% -3.89%
==========================================
Files 13 127 +114
Lines 856 5833 +4977
Branches 178 1122 +944
==========================================
+ Hits 821 5368 +4547
- Misses 35 465 +430
|
That's a good start. No incompatible packages anymore. I imagine api version range in peerDeps being invalid still for contrib packages. Will check those next. |
@@ -26,7 +26,7 @@ | |||
"@opentelemetry/api": "^1.0.2" | |||
}, | |||
"devDependencies": { | |||
"@opentelemetry/api": "1.0.2", | |||
"@opentelemetry/api": "1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
below quite some deps are pinned to fixed versions (github doesn't allow to comment there). I think we should ranges there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed those as well.
@@ -38,7 +38,7 @@ | |||
"@opentelemetry/api": "^1.0.2" | |||
}, | |||
"devDependencies": { | |||
"@opentelemetry/api": "1.0.2", | |||
"@opentelemetry/api": "1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are pinned versions in dependencies below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And these.
There are still some inconsistencies in the ranges used, e.g. sometimes we have "peerDependencies": {
"@opentelemetry/api": "^1.0.4"
},
"dependencies": {
"@opentelemetry/resources": "^1.0.1",
"@opentelemetry/semantic-conventions": "^1.0.1"
} but sometimes like this: "peerDependencies": {
"@opentelemetry/api": "^1.0.2"
},
"dependencies": {
"@opentelemetry/core": "^1.0.0",
"@opentelemetry/resources": "^1.0.0",
"@opentelemetry/semantic-conventions": "^1.0.0"
} I guess we should do some cleanup in this regard also but no need to do this in this PR. |
Another point (most likely also for a followup) is the version range used by components implementing API (propagators). On core we use a reduced range but not here. |
"@opentelemetry/sdk-trace-node": "^1.1.1", | ||
"@opentelemetry/resources": "^1.1.1", | ||
"@opentelemetry/sdk-trace-base": "^1.1.1", | ||
"@opentelemetry/semantic-conventions": "^1.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is here ^1.0.1
but the others are at ^1.1.1
?
At other places you moved to 1.1.x only for dep-dependencies but not for prod dependencies. So maybe it should be ^1.0.0
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only updated core packages that rely on api, semantic conventions does not.
Since it was 1.0.1
before, I didn't want to to downgrade the possible versions and just opened it up for upgrades.
seems long task is unhappy now because it uses 1.1.1 for sdk-trace-base but 1.0.1 for sdk-trace-web as latest tag was moved. |
We're going to redo this once the peerDependency ranges in core are fixed increasing lower bound on API in Trace SDK should've not done. An alternative would be to bump everything to 1.1 in contrib, which we agreed to not to do for now in SIG. But the point on propagators is valid - since propagators implement API they should have a similar mechanism to Core package and cap the full range of API versions they support. I'll fix that in another PR. |
Which problem is this PR solving?
Problem explained in open-telemetry/opentelemetry-js#2863
It's another experiment to see if we can get away without updating all the dependencies for now.
Short description of the changes
This is an alternative solution to #953