Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update OTel core deps and API #953

Closed
wants to merge 6 commits into from

Conversation

rauno56
Copy link
Member

@rauno56 rauno56 commented Mar 23, 2022

Which problem is this PR solving?

Problem explained in open-telemetry/opentelemetry-js#2863

Short description of the changes

Update everything to latest to make sure it's all in sync.

This is an alternative solution to #954

@Flarna
Copy link
Member

Flarna commented Mar 23, 2022

I think this requires also a release of experimental core modules as e.g. @opentelemetry/instrumentation 0.27.0 has 1.0.x of stable pinned.

@rauno56
Copy link
Member Author

rauno56 commented Mar 23, 2022

Yes... and @opentelemetry/exporter-trace-otlp-http(for @opentelemetry/browser-extension-autoinjection) which we cannot release right now because of the json exporter, or is it separate? @dyladan

@dyladan
Copy link
Member

dyladan commented Mar 23, 2022

open-telemetry/opentelemetry-js#2835 moves them all back to experimental, then we will make them not depend on each other, then we will move only proto and grpc to stable. JSON is being stabilized so the exporter can be released stable when that happens.

@rauno56 rauno56 closed this Mar 24, 2022
@rauno56 rauno56 reopened this Mar 24, 2022
@rauno56
Copy link
Member Author

rauno56 commented Mar 24, 2022

Sorry, misclicked "close".

Actually, @Flarna, I take that back. We don't need to release @opentelemetry/instrumentation because it's peerDependencies are as such: { '@opentelemetry/api': '^1.0.0' }. Which means they allow 1.x, not 1.0.x.

@rauno56 rauno56 force-pushed the chore/update-otel-deps branch from b7d655e to ad4b2b6 Compare March 24, 2022 16:41
@rauno56
Copy link
Member Author

rauno56 commented Mar 24, 2022

It seems like I've run of "PR quota" or something, the CI just doesn't run.
❤️ GHA

@Flarna
Copy link
Member

Flarna commented Mar 24, 2022

nope, github has some issues with actions, see here

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #953 (77daba8) into main (acd6a6f) will decrease coverage by 3.86%.
The diff coverage is 93.54%.

@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
- Coverage   95.91%   92.04%   -3.87%     
==========================================
  Files          13      127     +114     
  Lines         856     5833    +4977     
  Branches      178     1122     +944     
==========================================
+ Hits          821     5369    +4548     
- Misses         35      464     +429     
Impacted Files Coverage Δ
...tor-docker/src/detectors/DockerCGroupV1Detector.ts 93.33% <93.33%> (ø)
...ry-resource-detector-docker/src/detectors/index.ts 100.00% <100.00%> (ø)
...try-instrumentation-express/src/instrumentation.ts 94.77% <0.00%> (ø)
...er-extension-autoinjection/src/background/index.ts 0.00% <0.00%> (ø)
...r-aws-xray/src/platform/node/AWSXRayIdGenerator.ts 100.00% <0.00%> (ø)
...de/opentelemetry-instrumentation-knex/src/utils.ts 88.88% <0.00%> (ø)
...ode/opentelemetry-instrumentation-koa/src/types.ts 100.00% <0.00%> (ø)
...lemetry-instrumentation-net/src/instrumentation.ts 98.07% <0.00%> (ø)
...emetry-instrumentation-pino/src/instrumentation.ts 100.00% <0.00%> (ø)
...de/opentelemetry-instrumentation-hapi/src/utils.ts 100.00% <0.00%> (ø)
... and 104 more

@rauno56 rauno56 mentioned this pull request Mar 25, 2022
@rauno56
Copy link
Member Author

rauno56 commented Mar 25, 2022

Between this and #954, this is

  • probably safer because #954 doesn't take into account packages that have invalid peer dep ranges like 1.0.x versions of trace SDK.
  • more invasive for users because forces version 1.1.0 of the API.

@rauno56 rauno56 marked this pull request as ready for review March 25, 2022 15:11
@rauno56 rauno56 requested a review from a team March 25, 2022 15:11
@rauno56 rauno56 closed this Mar 28, 2022
@rauno56 rauno56 deleted the chore/update-otel-deps branch March 28, 2022 08:40
@rauno56
Copy link
Member Author

rauno56 commented Mar 28, 2022

I'm going to close this. All the conflicting deps are updated in #954.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants