Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(amqplib): add missing rabbit service to CI daily run #946

Merged
merged 3 commits into from
Mar 16, 2022

Conversation

blumamir
Copy link
Member

Which problem is this PR solving?

  • after amqplib is merged, the daily run of test-all-versions fails because I added the service only to unit-test.yml and forgot to add it to test-all-versions.yml.

Short description of the changes

  • add the required rabbitmq service also to test-all-versions.yml. This should fix the CI.

Checklist

  • Ran npm run test-all-versions for the edited package(s) on the latest commit if applicable.

@blumamir blumamir requested a review from a team March 16, 2022 09:07
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #946 (cf8be61) into main (b21b96c) will decrease coverage by 1.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #946      +/-   ##
==========================================
- Coverage   95.91%   94.87%   -1.04%     
==========================================
  Files          13       17       +4     
  Lines         856     1230     +374     
  Branches      178      267      +89     
==========================================
+ Hits          821     1167     +346     
- Misses         35       63      +28     
Impacted Files Coverage Δ
plugins/node/instrumentation-amqplib/src/types.ts 100.00% <0.00%> (ø)
plugins/node/instrumentation-amqplib/src/utils.ts 95.38% <0.00%> (ø)
...lugins/node/instrumentation-amqplib/src/amqplib.ts 90.40% <0.00%> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts 97.91% <0.00%> (ø)

Copy link
Member

@rauno56 rauno56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rauno56 rauno56 merged commit 5f63606 into open-telemetry:main Mar 16, 2022
@dyladan dyladan mentioned this pull request Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants