Skip to content

Commit

Permalink
fix(amqplib): add missing rabbit service to CI daily run (#946)
Browse files Browse the repository at this point in the history
* fix(amqplib): add missing rabbit service to CI daily run

* ci: don't run amqplib tav on node 8

Co-authored-by: Rauno Viskus <[email protected]>
  • Loading branch information
Amir Blum and rauno56 authored Mar 16, 2022
1 parent b21b96c commit 5f63606
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
8 changes: 8 additions & 0 deletions .github/workflows/test-all-versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ jobs:
--ignore @opentelemetry/instrumentation-aws-sdk
--ignore @opentelemetry/instrumentation-pino
--ignore @opentelemetry/instrumentation-tedious
--ignore @opentelemetry/instrumentation-amqplib
- node: "10"
lerna-extra-args: >-
--ignore @opentelemetry/instrumentation-pino
Expand Down Expand Up @@ -87,6 +88,13 @@ jobs:
image: bitnami/cassandra:3
ports:
- 9042:9042
rabbitmq:
image: rabbitmq:3
ports:
- 22221:5672
env:
RABBITMQ_DEFAULT_USER: username
RABBITMQ_DEFAULT_PASS: password
env:
RUN_CASSANDRA_TESTS: 1
RUN_MEMCACHED_TESTS: 1
Expand Down
2 changes: 1 addition & 1 deletion plugins/node/instrumentation-amqplib/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"compile": "npm run version:update && tsc -p .",
"lint": "eslint . --ext .ts",
"lint:fix": "eslint . --ext .ts --fix",
"precompile": "tsc --version && lerna run version --scope $(npm pkg get name) --include-dependencies",
"precompile": "tsc --version && lerna run version --scope @opentelemetry/instrumentation-amqplib --include-dependencies",
"prewatch": "npm run precompile",
"prepare": "npm run compile",
"tdd": "npm run test -- --watch-extensions ts --watch",
Expand Down

0 comments on commit 5f63606

Please sign in to comment.