fix!(ioredis): net.peer.ip -> db.connection_string

[trask]

BEGIN_COMMIT_OVERRIDE
fix(ioredis)!: net.peer.ip -> db.connection_string
END_COMMIT_OVERRIDE

This is split out of #913 because ioredis tests seem to hang CI.

[codecov]

Codecov Report

Merging #917 (ea0b3db) into main (5529261) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
- Coverage   95.91%   95.68%   -0.23%     
==========================================
  Files          13       16       +3     
  Lines         856      996     +140     
  Branches      178      198      +20     
==========================================
+ Hits          821      953     +132     
- Misses         35       43       +8     

Impacted Files	Coverage Δ
...try-instrumentation-ioredis/src/instrumentation.ts	91.46% <ø> (ø)
...tapackages/auto-instrumentations-node/src/utils.ts	97.87% <0.00%> (ø)
...opentelemetry-instrumentation-ioredis/src/utils.ts	100.00% <0.00%> (ø)

[trask]

@open-telemetry/javascript-approvers is this by any chance a known issue that CI is hanging on ioredis tests?

[vmarchaud]

cc @rauno56 since i think you worked a little bit on the ioredis tests ?

[dyladan]

@open-telemetry/javascript-approvers is this by any chance a known issue that CI is hanging on ioredis tests?

Not that I'm aware of

[trask]

what do you know, when I fixed the code, it fixed CI 😭 sorry for the noise

[dyladan]

what do you know, when I fixed the code, it fixed CI 😭 sorry for the noise

😮

[blumamir]

@dyladan - the name of the PR starts with fix!, how will release please handle that?
looks like it does not generate a release for the package

[dyladan]

According to this it should have treated it as breaking https://github.com/googleapis/release-please#how-should-i-write-my-commits