-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!(mysql*,redis): net.peer.ip -> db.connection_string #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #913 +/- ##
==========================================
- Coverage 95.91% 95.65% -0.26%
==========================================
Files 13 20 +7
Lines 856 1244 +388
Branches 178 244 +66
==========================================
+ Hits 821 1190 +369
- Misses 35 54 +19
|
trask
force-pushed
the
fix-db-connection-string
branch
2 times, most recently
from
February 21, 2022 02:41
7e237ce
to
de67ae5
Compare
trask
force-pushed
the
fix-db-connection-string
branch
from
February 22, 2022 05:28
57b084d
to
440f3c4
Compare
trask
force-pushed
the
fix-db-connection-string
branch
from
February 22, 2022 17:08
3998c69
to
7cd1828
Compare
trask
changed the title
fix(mysql*,*redis): net.peer.ip -> db.connection_string
fix(mysql*,redis): net.peer.ip -> db.connection_string
Feb 22, 2022
dyladan
approved these changes
Feb 22, 2022
WRT |
trask
changed the title
fix(mysql*,redis): net.peer.ip -> db.connection_string
fix!(mysql*,redis): net.peer.ip -> db.connection_string
Feb 22, 2022
Flarna
approved these changes
Feb 23, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
fix(mysql*,redis)!: net.peer.ip -> db.connection_string
END_COMMIT_OVERRIDE
Which problem is this PR solving?
net.peer.ip
attributeShort description of the changes
db.connection_string
attribute[I have other thoughts about whether
db.connection_string
should be captured at all in these cases (when it's a synthetically reconstructed value from existing telemetry data likenet.peer.name
,net.peer.port
,db.name
), but I will seek to clarify that point in the specification as it's unclear (see also open-telemetry/opentelemetry-java-instrumentation#3080)]