feat(instrumentation-document-load): documentLoad attributes enhancement #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkruk-sumo
commented
Apr 22, 2021
| assert.strictEqual(rootSpan.name, 'documentFetch'); | ||
| assert.strictEqual(fetchSpan.name, 'documentLoad'); | ||
| assert.strictEqual(fetchSpan.name, 'documentFetch'); | ||
| assert.strictEqual(rootSpan.name, 'documentLoad'); |
There was a problem hiding this comment.
documentLoad span is the root one so I think previous names were mistaken?
Codecov Report
@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 95.24% 95.25%
=======================================
Files 133 133
Lines 8252 8254 +2
Branches 810 810
=======================================
+ Hits 7860 7862 +2
Misses 392 392
|
johnbley
reviewed
Apr 23, 2021
plugins/web/opentelemetry-instrumentation-document-load/src/documentLoad.ts
Outdated
Show resolved
Hide resolved
kkruk-sumo
force-pushed
the
document_load_page_extra_attrs
branch
from
89a2495 to
80a6915
Compare
|
Approved this user to run tests in our CI |
@dyladan I had to merge |
Only needs to be done for first run. Everything after that works fine. |
dyladan
approved these changes
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR answers questions:
http.urland),page_titlehttp.user_agent).