Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-document-load): documentLoad attributes enhancement #433

Closed

Conversation

kkruk-sumo
Copy link
Contributor

Which problem is this PR solving?

This PR answers questions:

  • which website has been loaded (added http.url and page_title),
  • who visited it (added http.user_agent).

@kkruk-sumo kkruk-sumo requested a review from a team April 21, 2021 08:44
assert.strictEqual(rootSpan.name, 'documentFetch');
assert.strictEqual(fetchSpan.name, 'documentLoad');
assert.strictEqual(fetchSpan.name, 'documentFetch');
assert.strictEqual(rootSpan.name, 'documentLoad');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

documentLoad span is the root one so I think previous names were mistaken?

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #433 (c644641) into main (b128dae) will increase coverage by 3.83%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #433      +/-   ##
==========================================
+ Coverage   92.00%   95.83%   +3.83%     
==========================================
  Files           2       15      +13     
  Lines          25      624     +599     
  Branches        4       94      +90     
==========================================
+ Hits           23      598     +575     
- Misses          2       26      +24     
Impacted Files Coverage Δ
...metry-propagator-aws-xray/src/AWSXRayPropagator.ts 100.00% <0.00%> (ø)
...propagator-aws-xray/test/AWSXRayPropagator.test.ts 100.00% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/metric.ts 100.00% <0.00%> (ø)
...ages/opentelemetry-host-metrics/src/BaseMetrics.ts 57.57% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/enum.ts 100.00% <0.00%> (ø)
...ackages/opentelemetry-host-metrics/src/stats/si.ts 66.66% <0.00%> (ø)
...metry-propagator-ot-trace/src/OTTracePropagator.ts 95.83% <0.00%> (ø)
...s/opentelemetry-propagator-ot-trace/src/version.ts 0.00% <0.00%> (ø)
packages/opentelemetry-host-metrics/src/version.ts 100.00% <0.00%> (ø)
...ges/opentelemetry-host-metrics/test/metric.test.ts 96.52% <0.00%> (ø)
... and 3 more

@kkruk-sumo kkruk-sumo closed this Apr 22, 2021
@kkruk-sumo kkruk-sumo force-pushed the document_load_page_extra_attrs branch from c644641 to a2de775 Compare April 22, 2021 12:16
@kkruk-sumo
Copy link
Contributor Author

I messed up branch in fork repo so here is the re-created PR: #441 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant