Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ioredis): make flaky test deterministic #342

Merged
merged 4 commits into from
Feb 22, 2021

Conversation

blumamir
Copy link
Member

Which problem is this PR solving?

fixes #332
The test should create a child span for pubsub in ioredis plugin and instrumentation is creating two clients that send Redis commands asynchronously, which makes the output nondeterministic.

Short description of the changes

Make the test synchronously and deterministic by awaiting the connect function of each client before continuing to the following operations.

@blumamir blumamir requested a review from a team February 10, 2021 14:14
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #342 (40cbbb8) into main (c8b7f3d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #342   +/-   ##
=======================================
  Coverage   93.88%   93.88%           
=======================================
  Files          12       12           
  Lines         409      409           
  Branches       45       45           
=======================================
  Hits          384      384           
  Misses         25       25           

@obecny obecny merged commit 93b4bcc into open-telemetry:main Feb 22, 2021
@obecny obecny added the enhancement New feature or request label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ioredis: test is flaky
4 participants