Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ioredis: test is flaky #332

Closed
blumamir opened this issue Feb 2, 2021 · 0 comments · Fixed by #342
Closed

ioredis: test is flaky #332

blumamir opened this issue Feb 2, 2021 · 0 comments · Fixed by #342
Labels
bug Something isn't working

Comments

@blumamir
Copy link
Member

blumamir commented Feb 2, 2021

The test should create a child span for pubsub in ioredis instrumentation is flaky.
Detailed explanation about the cause can be found here.

I will fix the test and make it deterministic after the ioredis instrumentation PR is merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(ioredis): make flaky test deterministic blumamir/opentelemetry-js-contrib
1 participant
@blumamir