Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Koa plugin enhancements #326

Closed

Conversation

DinaYakovlev
Copy link
Contributor

Which problem is this PR solving?

In addition to #176 PR and to #273 We should able to instrument the root span name. This way it would be clear from the beginning on what request the span is about, and if in the future there would be an option to remove layers (like in the express plugin) the route will be in the root span.

Short description of the changes

using koa plugin before the change:
Before
using koa plugin after the change:
After

@DinaYakovlev DinaYakovlev requested a review from a team January 28, 2021 13:37
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 28, 2021

CLA Missing ID

@codecov
Copy link

codecov bot commented Jan 28, 2021

Codecov Report

Merging #326 (5a4dded) into main (234c42f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   95.41%   95.42%           
=======================================
  Files         115      115           
  Lines        6090     6100   +10     
  Branches      590      596    +6     
=======================================
+ Hits         5811     5821   +10     
  Misses        279      279           
Impacted Files Coverage Δ
...ode/opentelemetry-koa-instrumentation/src/types.ts 100.00% <0.00%> (ø)
.../node/opentelemetry-koa-instrumentation/src/koa.ts 98.46% <0.00%> (+0.27%) ⬆️

@DinaYakovlev DinaYakovlev deleted the koa-plugin-enhancements branch January 28, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant