-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enable root span route instrumentation without any express layer spans #273
feat: enable root span route instrumentation without any express layer spans #273
Conversation
|
Codecov Report
@@ Coverage Diff @@
## master #273 +/- ##
==========================================
+ Coverage 95.32% 95.35% +0.03%
==========================================
Files 115 115
Lines 5948 5991 +43
Branches 586 591 +5
==========================================
+ Hits 5670 5713 +43
Misses 278 278
|
d4a6da6
to
8fe3977
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very different behavior but it doesn't look like you added any configuration options. Am I missing something?
Hi @dyladan. |
…mo/opentelemetry-js-contrib into express-plugin-enhancements
@obecny Hi. i fix your comments on the unit test structure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thx for those changes
Which problem is this PR solving?
In addition to #176 PR, We should able to instrument the root span name when ignoring all express layers (router, middleware and request_handler).
This significantly reduces the amount of spans for a large and complex express based micro-service with large amount of outgoing http requests for a single incoming http request and still able to set the route on the root span.
Short description of the changes
using express with only request_handler layer before the change:
using express without request_handler, middleware and route layer (root span name not modified) before the change:
using express without request_handler, middleware and route layer after the change: