-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation-pg): implementation of metric operation duration #2380
feat(instrumentation-pg): implementation of metric operation duration #2380
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2380 +/- ##
==========================================
- Coverage 90.97% 90.77% -0.21%
==========================================
Files 146 156 +10
Lines 7492 7716 +224
Branches 1502 1584 +82
==========================================
+ Hits 6816 7004 +188
- Misses 676 712 +36
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maryliag thanks for your contribution :)
PR looks very good. I left one question I'm curious about before giving approval.
…trib into db-metric-duration
…trib into db-metric-duration
…trib into db-metric-duration
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…trib into db-metric-duration
…trib into db-metric-duration
@pichlermarc friendly ping if this can be merged |
…trib into db-metric-duration
…trib into db-metric-duration
Failing tests are unrelated, looks like some issue with the runners - I'll merge this in once they work again 🙂 |
…trib into db-metric-duration
…y-js-contrib into db-metric-duration
The test failures now seem related to the previous PR #2349 which seems to have introduced some flakiness in the tests. I've re-started, but it's something that we need to address. |
…s recorded for Promises API usage of pg Refs: open-telemetry#2380
Which problem is this PR solving?
Short description of the changes
This PR does not contain all attributes, because all the ones that require parsing of the query will be more complex and need dedicated testing for performance and be opt-in, so I will leave those for the next PR