-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation-pg): initial implementation of DB metrics #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2349 +/- ##
==========================================
- Coverage 90.97% 90.70% -0.27%
==========================================
Files 146 156 +10
Lines 7492 7664 +172
Branches 1502 1578 +76
==========================================
+ Hits 6816 6952 +136
- Misses 676 712 +36
|
maryliag
changed the title
initial implementation of prototype
feat(instrumentation-pg): initial implementation of prototype
Jul 24, 2024
10 tasks
maryliag
changed the title
feat(instrumentation-pg): initial implementation of prototype
feat(instrumentation-pg): initial implementation of DB metrics
Jul 31, 2024
pichlermarc
reviewed
Aug 20, 2024
plugins/node/opentelemetry-instrumentation-pg/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
…trib into db-metrics
pichlermarc
reviewed
Aug 21, 2024
plugins/node/opentelemetry-instrumentation-pg/test/pg-pool.test.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-pg/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-pg/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
…trib into db-metrics
…trib into db-metrics
pichlermarc
approved these changes
Sep 4, 2024
david-luna
approved these changes
Sep 5, 2024
@pichlermarc friendly ping if this can be merged |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes