Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-pg): initial implementation of DB metrics #2349

Merged
merged 48 commits into from
Sep 11, 2024

Conversation

maryliag
Copy link
Contributor

@maryliag maryliag commented Jul 24, 2024

Which problem is this PR solving?

Short description of the changes

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 96.87500% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.70%. Comparing base (dfb2dff) to head (c095d5a).
Report is 236 commits behind head on main.

Files with missing lines Patch % Lines
...elemetry-instrumentation-pg/src/instrumentation.ts 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2349      +/-   ##
==========================================
- Coverage   90.97%   90.70%   -0.27%     
==========================================
  Files         146      156      +10     
  Lines        7492     7664     +172     
  Branches     1502     1578      +76     
==========================================
+ Hits         6816     6952     +136     
- Misses        676      712      +36     
Files with missing lines Coverage Δ
...node/opentelemetry-instrumentation-pg/src/utils.ts 97.61% <100.00%> (+0.64%) ⬆️
...elemetry-instrumentation-pg/src/instrumentation.ts 88.67% <92.85%> (+0.70%) ⬆️

... and 74 files with indirect coverage changes

@maryliag maryliag changed the title initial implementation of prototype feat(instrumentation-pg): initial implementation of prototype Jul 24, 2024
@maryliag maryliag marked this pull request as ready for review July 26, 2024 13:36
@maryliag maryliag requested a review from a team July 26, 2024 13:36
@maryliag maryliag changed the title feat(instrumentation-pg): initial implementation of prototype feat(instrumentation-pg): initial implementation of DB metrics Jul 31, 2024
@maryliag
Copy link
Contributor Author

@pichlermarc friendly ping if this can be merged

@pichlermarc pichlermarc merged commit 12adb43 into open-telemetry:main Sep 11, 2024
14 checks passed
@dyladan dyladan mentioned this pull request Sep 10, 2024
@maryliag maryliag deleted the db-metrics branch September 11, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants