Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-winston): Allow log level to be configured for log sending #2016

Merged
merged 10 commits into from
Apr 19, 2024

Conversation

hectorhdzg
Copy link
Member

Which problem is this PR solving?

  • Allow users to configure severity level to be used by OpenTelemetry Winston Transport used in this instrumentation

Related to #1919

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

Merging #2016 (e69b6b3) into main (dfb2dff) will increase coverage by 4.14%.
Report is 59 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2016      +/-   ##
==========================================
+ Coverage   90.97%   95.12%   +4.14%     
==========================================
  Files         146       10     -136     
  Lines        7492      697    -6795     
  Branches     1502      142    -1360     
==========================================
- Hits         6816      663    -6153     
+ Misses        676       34     -642     

see 137 files with indirect coverage changes

@hectorhdzg
Copy link
Member Author

@trentm this one should be ready for another round, let me know if you have any feedback or concern

@trentm
Copy link
Contributor

trentm commented Apr 17, 2024

LGTM, thanks!

@hectorhdzg hectorhdzg merged commit b903bce into open-telemetry:main Apr 19, 2024
17 checks passed
@dyladan dyladan mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants