-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(instrumentation-bunyan): Allow log level to be configured for log sending #1919
feat(instrumentation-bunyan): Allow log level to be configured for log sending #1919
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1919 +/- ##
==========================================
- Coverage 90.97% 90.88% -0.10%
==========================================
Files 146 143 -3
Lines 7492 7402 -90
Branches 1502 1480 -22
==========================================
- Hits 6816 6727 -89
+ Misses 676 675 -1
|
Discussing on the issue: #1918 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just some nits.
plugins/node/opentelemetry-instrumentation-bunyan/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts
Outdated
Show resolved
Hide resolved
plugins/node/opentelemetry-instrumentation-bunyan/test/bunyan.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Which problem is this PR solving?
Fixes #1918