Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(instrumentation-bunyan): Allow log level to be configured for log sending #1919

Merged
merged 9 commits into from
Mar 11, 2024

Conversation

hectorhdzg
Copy link
Member

Which problem is this PR solving?

Fixes #1918

@github-actions github-actions bot requested a review from seemk February 1, 2024 23:50
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Merging #1919 (e9662bf) into main (dfb2dff) will decrease coverage by 0.10%.
Report is 9 commits behind head on main.
The diff coverage is 94.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1919      +/-   ##
==========================================
- Coverage   90.97%   90.88%   -0.10%     
==========================================
  Files         146      143       -3     
  Lines        7492     7402      -90     
  Branches     1502     1480      -22     
==========================================
- Hits         6816     6727      -89     
+ Misses        676      675       -1     
Files Coverage Δ
...etry-instrumentation-bunyan/src/instrumentation.ts 97.91% <94.73%> (-0.79%) ⬇️

... and 4 files with indirect coverage changes

@pichlermarc pichlermarc requested a review from trentm February 6, 2024 16:32
@trentm
Copy link
Contributor

trentm commented Feb 7, 2024

Discussing on the issue: #1918 (comment)

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some nits.

Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hectorhdzg hectorhdzg merged commit 4dc812e into open-telemetry:main Mar 11, 2024
17 checks passed
@dyladan dyladan mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[instrumentation-bunyan] Allow log level to be configured for auto instrumentation and BunyanStream
3 participants