docs: update typing guidelines #1881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1881 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 144 144
Lines 7406 7406
Branches 1483 1483
=======================================
Hits 6773 6773
Misses 633 633 |
Bumps [axios](https://github.com/axios/axios) from 0.21.4 to 1.6.0. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v0.21.4...v1.6.0) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…(security) (open-telemetry#1868) * chore: bump system info version to address arbitrary command injection vulnerability in systeminformation Signed-off-by: yyomba <[email protected]> * chore: sync package-lock.json --------- Signed-off-by: yyomba <[email protected]> Co-authored-by: Marc Pichler <[email protected]>
we may want information but still never stale it so set exempt label first for early return. any-of-label is comma-separated allowlist. remove instr-request and bug to avoid needing to remove labels. Co-authored-by: Marc Pichler <[email protected]>
) This is as a workaround for ESM testing failing with v18.19.0 due to node's off-thread ESM loading and import-in-the-middle's limitation with reexports. Refs: open-telemetry#1872
* fix(deps): update opentelemetry-js monorepo * fix(deps): update otel core experimental to ^0.46.0 * fix: re-generate package-lock.json * fix: test with updated import-in-the-middle hook * fix: use type-compatible versions of rxjs * fix(mongodb-example): remove unneeded useUnifiedTopology parameter * fix: remove iitm 1.7.2 again, use otel hook (iitm 1.7.1) --------- Co-authored-by: Mend Renovate <[email protected]>
* added maintainer for the react plugin * Update .github/component_owners.yml --------- Co-authored-by: Marc Pichler <[email protected]>
|
dont know how the other commits got it. Going to recreate the PR |
|
I think it's a great workaround for the breaking type issue and a welcome addition to the guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR showcases the use of generic types when exporting types to the public API that depend on the instrumented package.
The generic types approach seeks to avoid adding a types package as a dependency of the instrumentation because it may bring some problems to consumers like #1787
This approach has been added as a replacement of the
anytype approach since its the fallback type when using a genericShort description of the changes