Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: specify label for stale, exempt never-stale #1732

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

JamieDanielson
Copy link
Member

Which problem is this PR solving?

  • We recently in (fix: reconfigure stalebot to not close bugs #1709 ) exempted bug labels from stalebot; we then realized an issue may be labeled as a bug that should still go stale if no response, and the only way to avoid it going stale is to remove the bug label, which doesn't seem right either. We should be intentional about requesting information and letting issues and PRs go stale if necessary, without needing to remove labels to allow stalebot to come through.

Short description of the changes

  • add any-of-labels to the workflow, so any issue or PR labeled as "information-requested" is eligible for stalebot. This is comma-separated allow-list of labels. If we end up having different labels, we can add these here, and we can also get more granular later if needed with any-of-issue-labels and any-of-pr-labels.
  • remove instrumentation-request and bug from exempted labels, to allow stalebot to come through if it's appropriately labeled as "information-requested" (otherwise we'd need to remove the bug or instr-request label, or manually close).
  • intentionaly keep the never-stale labels for issue and PR. We may request more information but still want it to be never-stale, so keeping the exempt label first should allow for an early return.

we may want information but still never stale it
so set exempt label first for early return.
any-of-label is comma-separated allowlist.
remove instr-request and bug to avoid needing to remove labels.
@JamieDanielson JamieDanielson requested a review from a team October 12, 2023 14:47
@JamieDanielson JamieDanielson changed the title maint: specify label for stale, exempt never-stale chore: specify label for stale, exempt never-stale Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #1732 (9279f4b) into main (7e335c7) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1732   +/-   ##
=======================================
  Coverage   91.45%   91.45%           
=======================================
  Files         144      144           
  Lines        7406     7406           
  Branches     1483     1483           
=======================================
  Hits         6773     6773           
  Misses        633      633           

Copy link
Contributor

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Dec 18, 2023
Copy link
Member

@pichlermarc pichlermarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nooo, I forgot about this PR 😞
Sorry about that. Thank you for taking care of this @JamieDanielson

@pichlermarc pichlermarc removed the stale label Dec 19, 2023
@JamieDanielson
Copy link
Member Author

This is weird - I tried clicking Update Branch and I get this error:

Update branch attempt failed
Couldn't update "jamie.update-stalebot": Changes must be made through a pull request. Required status check "EasyCLA" is expected. You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more info

Am I missing something obvious?

@pichlermarc
Copy link
Member

pichlermarc commented Dec 20, 2023

This is weird - I tried clicking Update Branch and I get this error:

Update branch attempt failed
Couldn't update "jamie.update-stalebot": Changes must be made through a pull request. Required status check "EasyCLA" is expected. You're not authorized to push to this branch. Visit https://docs.github.com/articles/about-protected-branches/ for more info

Am I missing something obvious?

Ah looks like some branch protection rule was preventing that. I updated them to meet the guidelines set by the organization a while ago - looks like it was possible for approvers to create and push to a branch before, now it is not possible anymore.

@pichlermarc pichlermarc merged commit e35e370 into main Dec 20, 2023
14 checks passed
david-luna pushed a commit to david-luna/opentelemetry-js-contrib that referenced this pull request Dec 27, 2023
we may want information but still never stale it
so set exempt label first for early return.
any-of-label is comma-separated allowlist.
remove instr-request and bug to avoid needing to remove labels.

Co-authored-by: Marc Pichler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants