-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: specify label for stale, exempt never-stale #1732
Conversation
we may want information but still never stale it so set exempt label first for early return. any-of-label is comma-separated allowlist. remove instr-request and bug to avoid needing to remove labels.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1732 +/- ##
=======================================
Coverage 91.45% 91.45%
=======================================
Files 144 144
Lines 7406 7406
Branches 1483 1483
=======================================
Hits 6773 6773
Misses 633 633 |
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nooo, I forgot about this PR 😞
Sorry about that. Thank you for taking care of this @JamieDanielson
This is weird - I tried clicking Update Branch and I get this error:
Am I missing something obvious? |
Ah looks like some branch protection rule was preventing that. I updated them to meet the guidelines set by the organization a while ago - looks like it was possible for approvers to create and push to a branch before, now it is not possible anymore. |
we may want information but still never stale it so set exempt label first for early return. any-of-label is comma-separated allowlist. remove instr-request and bug to avoid needing to remove labels. Co-authored-by: Marc Pichler <[email protected]>
Which problem is this PR solving?
Short description of the changes
any-of-labels
to the workflow, so any issue or PR labeled as "information-requested" is eligible for stalebot. This is comma-separated allow-list of labels. If we end up having different labels, we can add these here, and we can also get more granular later if needed withany-of-issue-labels
andany-of-pr-labels
.