-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: various compilation errors #170
Conversation
By importing the and using the ConnectionConfig and PoolActualConfig types. Signed-off-by: Naseem <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
- Coverage 94.10% 93.69% -0.42%
==========================================
Files 74 67 -7
Lines 3582 3268 -314
Branches 387 354 -33
==========================================
- Hits 3371 3062 -309
+ Misses 211 206 -5 |
@dyladan I went down a rabbit hole here, and it appears that many things were failing due to core and/or other packages being out of date. I am left with a remaining error with the
Any idea what may be going on? |
@naseemkullah I believe that someone implemented a interface to generate span/trace ids in the last release, it might be coming from that |
This seems the most likely to me |
@naseemkullah i believe they are right. will leave a comment in the code on your PR if i can but here's a related comment on a koa PR related also to express: #144 (comment) |
@@ -46,7 +46,7 @@ | |||
"@opentelemetry/test-utils": "^0.9.0", | |||
"@opentelemetry/tracing": "0.10.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tracing being on 0.10.2 is what causes the randomSpanId
issue. api/core will update to 0.10.2 on fresh installs due to being set to ^0.10.2.
looks like in related places you bumped everything to 0.10.2/^0.10.2, so i'd prob do that here as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, thanks!
Signed-off-by: Naseem <[email protected]>
Signed-off-by: Naseem <[email protected]>
Signed-off-by: Naseem <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great !
Co-authored-by: Daniel Dyla <[email protected]>
@open-telemetry/javascript-maintainers I think we can merge this one so it can unblocks other PRs (ex: #144) |
Which problem is this PR solving?
Unblocks chore(deps): update all non-major dependencies #143
Deals with other compilation errors that were encountered with
ZoneContextManager
andContext.ROOT_CONTEXT
Short description of the changes