ioredis and redis DB semantic conventions

[naseemkullah]

towards #116

Want to do this one first, will likely follow up with more.

N.B. Now nothing in attributes points to which specific library (e.g.: ioredis) is being traced.

[naseemkullah]

typedocs 😍

[naseemkullah]

What to do about

test/userInteraction.nozone.test.ts:48:39 - error TS2345: Argument of type 'ZoneContextManager' is not assignable to parameter of type 'ContextManager'.
  The types returned by 'active()' are incompatible between these types.
    Type 'import("/root/project/plugins/web/opentelemetry-plugin-user-interaction/node_modules/@opentelemetry/context-base/build/src/context").Context' is not assignable to type 'import("/root/project/plugins/web/opentelemetry-plugin-user-interaction/node_modules/@opentelemetry/api/node_modules/@opentelemetry/context-base/build/src/context").Context'.
      Types have separate declarations of a private property '_currentContext'.

48       context.setGlobalContextManager(contextManager);
                                         ~~~~~~~~~~~~~~

test/userInteraction.test.ts:51:39 - error TS2345: Argument of type 'ZoneContextManager' is not assignable to parameter of type 'ContextManager'.

51       context.setGlobalContextManager(contextManager);

?

[naseemkullah]

Now includes redis as well...

[dyladan]

I'm not sure about the build failure, but my best guess is that you bumped the core versions for some, but not all, of the main packages. i would revert those changes as they are not relevant here.

[naseemkullah]

I'm not sure about the build failure, but my best guess is that you bumped the core versions for some, but not all, of the main packages. i would revert those changes as they are not relevant here.

Very well, I'll let renovate bot do its job!

[naseemkullah]

Still failing despite leaving unrelated packages alone

> @opentelemetry/[email protected] version:update /root/project/plugins/web/opentelemetry-plugin-user-interaction
> node ../../../scripts/version-update.js

test/userInteraction.nozone.test.ts:48:39 - error TS2345: Argument of type 'ZoneContextManager' is not assignable to parameter of type 'ContextManager'.
  The types returned by 'active()' are incompatible between these types.
    Type 'import("/root/project/plugins/web/opentelemetry-plugin-user-interaction/node_modules/@opentelemetry/context-base/build/src/context").Context' is not assignable to type 'import("/root/project/plugins/web/opentelemetry-plugin-user-interaction/node_modules/@opentelemetry/api/node_modules/@opentelemetry/context-base/build/src/context").Context'.
      Types have separate declarations of a private property '_currentContext'.

48       context.setGlobalContextManager(contextManager);
                                         ~~~~~~~~~~~~~~

test/userInteraction.test.ts:51:39 - error TS2345: Argument of type 'ZoneContextManager' is not assignable to parameter of type 'ContextManager'.

51       context.setGlobalContextManager(contextManager);
                                         ~~~~~~~~~~~~~~


Found 2 errors.

[codecov]

Codecov Report

Merging #167 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
- Coverage   94.11%   94.06%   -0.05%     
==========================================
  Files          74       72       -2     
  Lines        3583     3558      -25     
  Branches      387      385       -2     
==========================================
- Hits         3372     3347      -25     
  Misses        211      211              

Impacted Files	Coverage Δ
node/opentelemetry-plugin-redis/src/utils.ts	90.90% <0.00%> (ø)
node/opentelemetry-plugin-ioredis/src/utils.ts	85.36% <0.00%> (ø)
node/opentelemetry-plugin-ioredis/src/ioredis.ts	100.00% <0.00%> (ø)
node/opentelemetry-plugin-redis/test/redis.test.ts	93.26% <0.00%> (ø)
.../opentelemetry-plugin-ioredis/test/ioredis.test.ts	95.30% <0.00%> (ø)
node/opentelemetry-plugin-redis/src/enums.ts
node/opentelemetry-plugin-ioredis/src/enums.ts

[vmarchaud]

lgtm