-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added MetricReader customizer for AutoConfiguredOpenTelemetrySdkBuilder #6231
Added MetricReader customizer for AutoConfiguredOpenTelemetrySdkBuilder #6231
Conversation
This is the second step for #6179, since without you currently won't be able to modify a Prometheus reader created by |
@jack-berg This is the 2nd step required for me to use it in Apache Pulsar. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6231 +/- ##
=========================================
Coverage 91.06% 91.06%
- Complexity 5695 5699 +4
=========================================
Files 621 621
Lines 16667 16679 +12
Branches 1707 1709 +2
=========================================
+ Hits 15177 15188 +11
- Misses 997 998 +1
Partials 493 493 ☔ View full report in Codecov by Sentry. |
...stFullConfig/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkTest.java
Outdated
Show resolved
Hide resolved
...stFullConfig/java/io/opentelemetry/sdk/autoconfigure/AutoConfiguredOpenTelemetrySdkTest.java
Outdated
Show resolved
Hide resolved
.../testFullConfig/java/io/opentelemetry/sdk/autoconfigure/MetricExporterConfigurationTest.java
Outdated
Show resolved
Hide resolved
.../testFullConfig/java/io/opentelemetry/sdk/autoconfigure/MetricExporterConfigurationTest.java
Outdated
Show resolved
Hide resolved
@jack-berg Fixed all comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one last comment about a possible extra dependency.
@jack-berg Fixed |
Added an ability to customize a
MetricReader
created atAutoConfiguredOpenTelemetrySdkBuilder
by allowing to specify a BiFunction which accepts aMetricReader
and the configuration and returns aMetricReader
. This allows the user to create a new MetricReader either based on the one created byAutoConfiguredOpenTelemetrySdkBuilder
or a completely new one.