Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Finalize design of new interfaces #2

Closed
tedsuo opened this issue Mar 19, 2019 · 0 comments
Closed

Finalize design of new interfaces #2

tedsuo opened this issue Mar 19, 2019 · 0 comments
Assignees
@carlosalberto @bogdandrutu @yurishkuro @SergeyKanzhelev

Comments

@tedsuo
Copy link
Contributor

tedsuo commented Mar 19, 2019 •
edited
Loading

Step 1

All issues labeled Terminology alignment must be marked as Agreed in order to close this issue.

Terminology: https://github.com/bogdandrutu/openconsensus/issues?q=is%3Aissue+is%3Aopen+label%3A%22Terminology+alignment%22

Step 2

All Agreed upon terminology must be implemented. Close each terminology ticket when this is complete.

Prior Research and Discussion
@tedsuo tedsuo added this to the Step 1: Spike to verify new API in Java milestone Mar 19, 2019
@tedsuo tedsuo mentioned this issue Apr 1, 2019
Closed
3 tasks
@tedsuo tedsuo removed this from the Step 1: Spike to verify new API in Java milestone Apr 19, 2019
@tedsuo tedsuo closed this as completed Apr 19, 2019
jkwatson referenced this issue in jkwatson/opentelemetry-java Aug 26, 2020
� This is a combination of 2 commits.
6a1d535 
� This is the 1st commit message:

WIP on converting to String-based SpanContext

don't hand out the byte arrays publicly, but require making copies

make sure to hand out fresh invalid byte arrays.

Use strings for span and trace ids.

Switch over to CharSequence instead of String for the ids

Fix a couple of places that were casting to String

Add some simple wrappers for the generated longs to save converting until the last moment to the character-based representation.

introduce a reusable threadlocal char buffer for generating random ids.

update for changes from upstream

Change the SpanContext to store the ids as Strings internally
Change the id access methods on SpanContext to be clearly labeled as the base16 representations
Add a new create method that allows specifying offsets for traceId and spanId CharSequences

Provide an option for creating a SpanContext from longs or Strings, optionally.

fix a typo

update from upstream

� The commit message #2 will be skipped:

� don't hand out the byte arrays publicly, but require making copies
jkwatson referenced this issue in jkwatson/opentelemetry-java Aug 26, 2020
� This is a combination of 2 commits.
04f76d2 
� This is the 1st commit message:

WIP on converting to String-based SpanContext

don't hand out the byte arrays publicly, but require making copies

make sure to hand out fresh invalid byte arrays.

Use strings for span and trace ids.

Switch over to CharSequence instead of String for the ids

Fix a couple of places that were casting to String

Add some simple wrappers for the generated longs to save converting until the last moment to the character-based representation.

introduce a reusable threadlocal char buffer for generating random ids.

update for changes from upstream

Change the SpanContext to store the ids as Strings internally
Change the id access methods on SpanContext to be clearly labeled as the base16 representations
Add a new create method that allows specifying offsets for traceId and spanId CharSequences

Provide an option for creating a SpanContext from longs or Strings, optionally.

fix a typo

update from upstream

� The commit message #2 will be skipped:

� don't hand out the byte arrays publicly, but require making copies
jkwatson referenced this issue in jkwatson/opentelemetry-java Sep 1, 2020
� This is a combination of 2 commits.
8a9760c 
� This is the 1st commit message:

WIP on converting to String-based SpanContext

don't hand out the byte arrays publicly, but require making copies

make sure to hand out fresh invalid byte arrays.

Use strings for span and trace ids.

Switch over to CharSequence instead of String for the ids

Fix a couple of places that were casting to String

Add some simple wrappers for the generated longs to save converting until the last moment to the character-based representation.

introduce a reusable threadlocal char buffer for generating random ids.

update for changes from upstream

Change the SpanContext to store the ids as Strings internally
Change the id access methods on SpanContext to be clearly labeled as the base16 representations
Add a new create method that allows specifying offsets for traceId and spanId CharSequences

Provide an option for creating a SpanContext from longs or Strings, optionally.

fix a typo

update from upstream

� The commit message #2 will be skipped:

� don't hand out the byte arrays publicly, but require making copies
jkwatson added a commit that referenced this issue Sep 3, 2020
@jkwatson @anuraaga
SpanContext hides the TraceId/SpanId implementations (#1594)
485cc52 
* � This is a combination of 2 commits.
� This is the 1st commit message:

WIP on converting to String-based SpanContext

don't hand out the byte arrays publicly, but require making copies

make sure to hand out fresh invalid byte arrays.

Use strings for span and trace ids.

Switch over to CharSequence instead of String for the ids

Fix a couple of places that were casting to String

Add some simple wrappers for the generated longs to save converting until the last moment to the character-based representation.

introduce a reusable threadlocal char buffer for generating random ids.

update for changes from upstream

Change the SpanContext to store the ids as Strings internally
Change the id access methods on SpanContext to be clearly labeled as the base16 representations
Add a new create method that allows specifying offsets for traceId and spanId CharSequences

Provide an option for creating a SpanContext from longs or Strings, optionally.

fix a typo

update from upstream

� The commit message #2 will be skipped:

� don't hand out the byte arrays publicly, but require making copies

* WIP on converting to String-based SpanContext

* Update the SpanContext to only store Strings internally for Trace and Span ids.

* remove dead files

* cleanup some CharSequence usages to String

* Update api/src/main/java/io/opentelemetry/trace/BigendianEncoding.java

Co-authored-by: Anuraag Agrawal <[email protected]>

* Update extensions/trace_propagators/src/main/java/io/opentelemetry/extensions/trace/propagation/B3PropagatorInjectorSingleHeader.java

Co-authored-by: Anuraag Agrawal <[email protected]>

* Update api/src/main/java/io/opentelemetry/trace/SpanId.java

Co-authored-by: Anuraag Agrawal <[email protected]>

* Update api/src/main/java/io/opentelemetry/trace/TraceId.java

Co-authored-by: Anuraag Agrawal <[email protected]>

* updates from PR suggestion fubars

* some cleanup from PR feedback

* Switch back to String from CharSequence

* Get rid of the overload with the offsets

* Lots of bits of cleanup from PR feedback.

* more renaming of base16 to hex

Co-authored-by: Anuraag Agrawal <[email protected]>
@jkwatson jkwatson mentioned this issue Nov 2, 2020
Closed
@anuraaga anuraaga mentioned this issue Feb 4, 2021
Closed
tnevolin added a commit to lightstep/opentelemetry-java that referenced this issue Oct 14, 2021
@tnevolin
Created new subproject for otlp-http-json open-telemetry#2.
441a697
tnevolin added a commit to lightstep/opentelemetry-java that referenced this issue Oct 19, 2021
@tnevolin
Replaced hardcoded localhost with OS resolved localhost name in tests. …
b70b0ce 
…open-telemetry#2
jkwatson pushed a commit that referenced this issue Oct 20, 2021
@tnevolin
Replaced hardcoded test host name with the one properly resolved by OS (
9cea4ef 
#3770)

* Replaced hardcoded localhost with OS resolved localhost name in tests.

* Replaced hardcoded localhost with OS resolved localhost name in tests. #2

* retrigger checks #1
@jsuereth jsuereth mentioned this issue Dec 17, 2021
Closed
@jsuereth jsuereth mentioned this issue Jan 14, 2022
Merged
asafm added a commit to streamnative/opentelemetry-java that referenced this issue Feb 21, 2024
@asafm
PR Fixes open-telemetry#2
51b8f1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosalberto carlosalberto

@bogdandrutu bogdandrutu

@yurishkuro yurishkuro

@SergeyKanzhelev SergeyKanzhelev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@tedsuo @carlosalberto @bogdandrutu @yurishkuro @SergeyKanzhelev