Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement jaeger exporter provider #5002

Merged
merged 1 commit into from
Dec 17, 2022

Conversation

jack-berg
Copy link
Member

Related to #4949.

Depends on #4993 since the existing jaeger exporter configuration configures JaegerSpanExporterBuilder#setMeterProvider.

@jack-berg jack-berg requested a review from a team November 29, 2022 19:33
@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Base: 91.23% // Head: 91.24% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (7fa1691) compared to base (e79aad8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5002      +/-   ##
============================================
+ Coverage     91.23%   91.24%   +0.01%     
- Complexity     4865     4867       +2     
============================================
  Files           552      553       +1     
  Lines         14399    14399              
  Branches       1373     1373              
============================================
+ Hits          13137    13139       +2     
+ Misses          873      872       -1     
+ Partials        389      388       -1     
Impacted Files Coverage Δ
...aeger/internal/JaegerGrpcSpanExporterProvider.java 100.00% <100.00%> (ø)
...y/sdk/autoconfigure/SpanExporterConfiguration.java 100.00% <100.00%> (ø)
...y/exporter/internal/marshal/CodedOutputStream.java 71.00% <0.00%> (+1.18%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

This PR was marked stale due to lack of activity. It will be closed in 14 days.

@github-actions github-actions bot added the Stale label Dec 14, 2022
@jack-berg jack-berg merged commit 10e32fe into open-telemetry:main Dec 17, 2022
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants