Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor autoconfigure to implement exporter provider SPIs #4949

Closed
jack-berg opened this issue Nov 14, 2022 · 0 comments · Fixed by #5060
Closed

Refactor autoconfigure to implement exporter provider SPIs #4949

jack-berg opened this issue Nov 14, 2022 · 0 comments · Fixed by #5060
Labels
Feature Request Suggest an idea for this project

Comments

@jack-berg
Copy link
Member

Discussed in this comment.

Autoconfigure currently has compileOnly dependencies the exporter modules, along with a bunch of exporter-specific configuration to extract the relevant properties ConfigProperties and configure exporters. It makes autoconfigure pretty cumbersome to maintain, since there are test suites verifying the configured behavior of different exporters.

It would be better for maintainability and separation of concerns if the tests and the configuration code where decentralized and lived in the exporter modules. The stability of :sdk:autoconfigure-spi makes this straight forward to implement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant