Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android desugaring for HashMap.forEach #4221

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Feb 28, 2022

Resolves #4161
Android desugaring is not smart enough to handle calling HashMap.forEach through Attributes.forEach. This pr helps out desugaring by adding an explicit call to HashMap.forEach that desugaring can rewrite it.

@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #4221 (ed04d74) into main (963bc38) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #4221      +/-   ##
============================================
- Coverage     90.29%   90.28%   -0.01%     
  Complexity     4754     4754              
============================================
  Files           556      556              
  Lines         14609    14611       +2     
  Branches       1402     1402              
============================================
+ Hits          13191    13192       +1     
  Misses          959      959              
- Partials        459      460       +1     
Impacted Files Coverage Δ
...java/io/opentelemetry/sdk/trace/AttributesMap.java 100.00% <100.00%> (ø)
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 94.11% <0.00%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963bc38...ed04d74. Read the comment docs.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we log a bug against the Android Gradle Plugin for this case explicitly? Or, can you add your findings to https://issuetracker.google.com/issues/202188674

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anuraaga anuraaga merged commit 26dd896 into open-telemetry:main Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbstractMethodError crash on Android
3 participants