Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix android desugaring for HashMap.forEach #5468

Merged
merged 1 commit into from
Feb 28, 2022

Conversation

laurit
Copy link
Contributor

@laurit laurit commented Feb 28, 2022

See open-telemetry/opentelemetry-java#4161 and open-telemetry/opentelemetry-java#4221
Android desugaring is not smart enough to handle calling HashMap.forEach through Attributes.forEach. This pr helps out desugaring by adding an explicit call to HashMap.forEach that desugaring can rewrite it.

@laurit laurit requested a review from a team February 28, 2022 18:58
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@anuraaga anuraaga merged commit c8c115d into open-telemetry:main Feb 28, 2022
RashmiRam pushed a commit to RashmiRam/opentelemetry-auto-instr-java that referenced this pull request May 23, 2022
@laurit laurit deleted the android-desugar-foreach branch July 6, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants