-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
labels processor #2964
Merged
bogdandrutu
merged 4 commits into
open-telemetry:main
from
as-polyakov:metrics-labels-processor-labels-processor
Mar 5, 2021
Merged
labels processor #2964
bogdandrutu
merged 4 commits into
open-telemetry:main
from
as-polyakov:metrics-labels-processor-labels-processor
Mar 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as-polyakov
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
March 2, 2021 21:45
jkwatson
reviewed
Mar 2, 2021
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/view/ViewBuilder.java
Outdated
Show resolved
Hide resolved
jkwatson
reviewed
Mar 2, 2021
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SynchronousInstrumentAccumulator.java
Show resolved
Hide resolved
jkwatson
reviewed
Mar 3, 2021
...metrics/src/test/java/io/opentelemetry/sdk/metrics/SynchronousInstrumentAccumulatorTest.java
Outdated
Show resolved
Hide resolved
jkwatson
approved these changes
Mar 3, 2021
bogdandrutu
reviewed
Mar 4, 2021
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/processor/LabelsProcessorFactory.java
Show resolved
Hide resolved
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/view/ViewBuilder.java
Show resolved
Hide resolved
...metrics/src/test/java/io/opentelemetry/sdk/metrics/SynchronousInstrumentAccumulatorTest.java
Outdated
Show resolved
Hide resolved
bogdandrutu
reviewed
Mar 4, 2021
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/view/ViewBuilder.java
Outdated
Show resolved
Hide resolved
bogdandrutu
approved these changes
Mar 5, 2021
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/view/ViewBuilder.java
Show resolved
Hide resolved
This was referenced Dec 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is an implementation for #1810. Based on #2956 and whole idea is sketched in this PR #2800