-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introducing view #2956
Merged
bogdandrutu
merged 2 commits into
open-telemetry:main
from
as-polyakov:metrics-labels-processor-view
Mar 2, 2021
Merged
introducing view #2956
bogdandrutu
merged 2 commits into
open-telemetry:main
from
as-polyakov:metrics-labels-processor-view
Mar 2, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
as-polyakov
commented
Mar 1, 2021
•
edited
Loading
edited
- View class as an overarching concept for AggregationFactory. In the future we can add more specifics into it
- The grand idea here is basically based around OpenCensus Views. We want to be able to register custom projections (views) on the metrics which would allow us to use different aggregations and pre-processing techniques.
- This is the very first step where we just introduce a view and wrap existing AggregatorFacotry
- Immediately next we would like to have LabelsProcessors added to the views which are going to be a separate PR, but at a glance - same thing we discussed in MetricsProcessor #1810. Whole PR might be found here introduction of View and first version of LabelsProessor #2800
as-polyakov
requested review from
anuraaga,
arminru,
bogdandrutu,
carlosalberto,
jkwatson,
Oberon00,
pavolloffay,
thisthat and
tylerbenson
as code owners
March 1, 2021 18:26
jkwatson
reviewed
Mar 1, 2021
bogdandrutu
reviewed
Mar 1, 2021
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/ViewRegistry.java
Outdated
Show resolved
Hide resolved
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/view/View.java
Outdated
Show resolved
Hide resolved
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/view/View.java
Outdated
Show resolved
Hide resolved
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/SdkMeterProvider.java
Outdated
Show resolved
Hide resolved
Can you give any hints about what you intend to add to Views? Maybe a design document with some ideas? I'm all on board with supporting opencensus style views, but I'd like to understand where we're going with the approach in this PR. |
bogdandrutu
approved these changes
Mar 2, 2021
This was referenced Dec 19, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.