Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introducing view #2956

Merged

Conversation

as-polyakov
Copy link
Contributor

@as-polyakov as-polyakov commented Mar 1, 2021

  • View class as an overarching concept for AggregationFactory. In the future we can add more specifics into it
  • The grand idea here is basically based around OpenCensus Views. We want to be able to register custom projections (views) on the metrics which would allow us to use different aggregations and pre-processing techniques.
  • This is the very first step where we just introduce a view and wrap existing AggregatorFacotry
  • Immediately next we would like to have LabelsProcessors added to the views which are going to be a separate PR, but at a glance - same thing we discussed in MetricsProcessor #1810. Whole PR might be found here introduction of View and first version of LabelsProessor #2800

@jkwatson
Copy link
Contributor

jkwatson commented Mar 1, 2021

Can you give any hints about what you intend to add to Views? Maybe a design document with some ideas? I'm all on board with supporting opencensus style views, but I'd like to understand where we're going with the approach in this PR.

@bogdandrutu
Copy link
Member

@jkwatson I think the next steps are in #1810

@jkwatson
Copy link
Contributor

jkwatson commented Mar 2, 2021

@jkwatson I think the next steps are in #1810

We should just be clear at this point that this is all very prototype work. This isn't in any specification yet, and is extremely likely to be re-worked before metrics get to 1.0.

@bogdandrutu bogdandrutu merged commit c7861e8 into open-telemetry:main Mar 2, 2021
This was referenced Mar 2, 2021
This was referenced Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants