Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buildscripts/semantic-convention/generate.sh script #2144

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Fix buildscripts/semantic-convention/generate.sh script #2144

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9678f4a
Fix buildscripts/semantic-convention/generate.sh script
Nov 26, 2020
1316e20
Code review comments
Nov 30, 2020
8770884
Reference spec date
Dec 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions buildscripts/semantic-convention/generate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
ROOT_DIR="${SCRIPT_DIR}/../../"
# freeze the spec version to make SemanticAttributes generation reproducible
# this hash was obtained by calling `git rev-parse master`
mateuszrzeszutek marked this conversation as resolved.
Show resolved Hide resolved
# we can't use a version tag here because otel-spec releases are very rare
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi I brought this up in the spec meeting this morning, so it's at least on people's radar.

SPEC_VERSION=d328331ce9dc6dec871b647b4e37a84b5396516e
mateuszrzeszutek marked this conversation as resolved.
Show resolved Hide resolved

cd ${SCRIPT_DIR}
Expand Down